Grant Coady: Incorrectly removed symbol from linux/pci_ids.h

Submitted by Anonymous
on December 28, 2006 - 9:20am

A patch by Grant Coady on Sep 28 2005 removed the #define PCI_DEVICE_ID_AKS_CPC from the 2.6.14-rc2 kernel, as un-referenced. This is incorrect, as HASP driver version 1.6 from Aladdin Knowledge Systems uses this #define.

Thanks,

Carlos A. R. Azevedo

Your driver is supposed to be in the kernel tree

on
December 28, 2006 - 9:39am

Breakage of this type is deliberate punishment for trying to maintain a closed-source driver (as in Windows). Closed source drivers force us in the Linux community to rely on people such as "Aladdin Knowledge Systems", "IBM", etc. to provide timely updates so we can use new features in new kernels (such as the kernel virtualization that will soon appear in 2.6.20), or to run new motherboards that require the absolute newest kernel. It can also create an impossible situation where we need one version of the kernel for certain hardware, another version for your HASP driver, etc..

The kernel developers do not worry at all about those trying to maintain "illegal closed source drivers" (their terminology) when cleaning unused non-GPL interface symbols, because "unused" means "not used by any modules in the kernel tree, or any modules being considered for inclusion in the kernel tree". The proper way is for your driver to be submitted to the kernel.org people for inclusion/maintenance, or move its functionality into userspace.

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.