setuid bit removed from login(1)

Submitted by ebola
on February 27, 2004 - 1:52am

des 2004/02/27 00:39:16 PST

FreeBSD src repository

Modified files:
usr.bin/login Makefile
Log:
Cut through the bikeshed and remove login(1)'s setuid bit. It has no
business trying to impersonate su(1), and it does not need to be setuid
to function properly when invoked by getty(8) or telnetd(8).

Revision Changes Path
1.44 +0 -3 src/usr.bin/login/Makefile

Oh my, things change quickly in the -CURRENT world.

ebola
on
February 28, 2004 - 5:25am

Well, after complaints of login(1) breaking when used by a shell, conditional support for removing the setuid bit on login(1) can be done by defining NO_SETUID_LOGIN.

Modified files:
usr.bin/login Makefile
Log:
Re-add the setuid bit, conditional on NO_SETUID_LOGIN being undefined.

Revision Changes Path
1.45 +5 -0 src/usr.bin/login/Makefile

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.