Re: [Tux3] Bug? Atom refcounting redux

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <tux3@...>, <james_avera@...>
Date: Tuesday, December 2, 2008 - 1:04 am

Looking at your post, it just occurred to me, we should change all our
breads from:

if (!(buffer = bread(inode->map, block)))
return -EIO;

to something like:

if (!(buffer = blockread(inode->map, block, &err)))
return err;

This way we can stop propagating the traditional silliness of inventing
our own error code when bread returns NULL. Our motto: "Tux3, we are
not part of the problem".

Regards,

Daniel

_______________________________________________
Tux3 mailing list
Tux3@tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Tux3] Bug? Atom refcounting redux, Jim Avera, (Mon Dec 1, 10:38 pm)
[Tux3] Page cache emulation now up and running, Daniel Phillips, (Sun Aug 10, 7:14 am)
Re: [Tux3] Bug? Atom refcounting redux, Daniel Phillips, (Tue Dec 2, 1:04 am)
Re: [Tux3] Bug? Atom refcounting redux, Daniel Phillips, (Tue Dec 2, 1:19 am)
Re: [Tux3] Bug? Atom refcounting redux, OGAWA Hirofumi, (Tue Dec 2, 5:44 am)
Re: [Tux3] Bug? Atom refcounting redux, Daniel Phillips, (Tue Dec 2, 4:07 pm)
Re: [Tux3] Bug? Atom refcounting redux, Daniel Phillips, (Tue Dec 2, 12:56 am)