... it prevents the > kernel to finish booting on my (Penryn based) laptop. ... memory. Took a while to bisect (due to it > touching page*. ... patch itself fixes a real regression and it's not obviously ... and if the box still boots, send us the stackdumps. (if ...

linux-kernel - Ingo Molnar - Mar 3 2008 - 03:46

... it prevents the kernel to finish booting on my (Penryn based) > laptop. ... init memory. > Took a while to bisect (due to it touching page*. ... arjan@localhost linux.trees.git]$ git-bisect good > cded932b75ab0a5f9181ee3da34a0a488d1a14fd is first bad commit ...

linux-kernel - Nish Aravamudan - Mar 3 2008 - 13:15

... .c:387 pmd_bad+0x44/0x53() > Modules linked in: > Pid: 1, comm: swapper Not tainted 2.6.25-rc3 #14 > [] warn_on_slowpath+0x41/0x67 > [] ? native_sched_clock+0x94/0xa6 > [] ? lock_release_holdtime+0x1a/0x115 ...

linux-kernel - Ingo Molnar - Mar 3 2008 - 13:40

... linked in: > > Pid: 1, comm: swapper Not tainted 2.6.25-rc3 #14 > > [] warn_on_slowpath+0x41/0x67 > > [] ? native_sched_clock+0x94/0xa6 > > [] ? lock_release_holdtime+0x1a/0x115 > > ...

linux-kernel - Nish Aravamudan - Mar 3 2008 - 13:51

... pmd_bad+0x44/0x53() >> Modules linked in: >> Pid: 1, comm: swapper Not tainted 2.6.25-rc3 #14 >> [] warn_on_slowpath+0x41/0x67 >> [] ? native_sched_clock+0x94/0xa6 >> [] ? lock_release_holdtime+0x1a/0x115 ...

linux-kernel - Arjan van de Ven - Mar 3 2008 - 14:36

... one below (it should solve Arjan's regression with that now-reverted patch redone), as ... trickles over into PAGE_MASK as well]. It boots fine on a >4GB box of mine but ... commit. I'll send this and the re-done hugetlbfs fix together early next week. ...

linux-kernel - Ingo Molnar - Mar 9 2008 - 07:56

On Sun, 9 Mar 2008, Ingo Molnar wrote: > > The best fix is the one below (it should solve Arjan's regression with > that now-reverted patch redone), as it is the right thing to do [that > way sign auto-extend trickles over into PAGE_MASK as well ...

linux-kernel - Linus Torvalds - Mar 9 2008 - 13:27

... .c:387 pmd_bad+0x44/0x53() Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.25-rc3 #14 [] warn_on_slowpath+0x41/0x67 [] ? native_sched_clock+0x94/0xa6 [] ? lock_release_holdtime+0x1a/0x115 ...

linux-kernel - Arjan van de Ven - Mar 3 2008 - 12:41

* Nish Aravamudan wrote: > > in any case, the commit has to be reverted as it clearly isnt a NOP > > on your box as it was intended to be. (it should only have made a > > difference in a rare hugetlbfs case) > >

linux-kernel - Ingo Molnar - Mar 3 2008 - 13:55

Ingo Molnar wrote: > * Nish Aravamudan wrote: > >>> in any case, the commit has to be reverted as it clearly isnt a NOP >>> on your box as it was intended to be. (it should only have made a >>> difference in a rare

linux-kernel - H. Peter Anvin - Mar 3 2008 - 13:58

>> hm. I suspect some gcc related difference related to the handling of >> this masking: >> pmd_val(x) & ~(PAGE_MASK | _PAGE_USER | _PAGE_PSE | _PAGE_NX) >> versus: >> pmd_val(x) & (~PAGE_MASK & ~_PAGE_USER) >> perhaps it will work if you

linux-kernel - Segher Boessenkool - Mar 3 2008 - 17:13

... same behavior yet; so > it's some fun interaction ;( > > more staring at the assembly for me could you post the "bad" and the "good" disassembled functions, and the specific gcc version string? Ingo -- To unsubscribe from this list: send ...

linux-kernel - Ingo Molnar - Mar 4 2008 - 02:53

... the same behavior yet; so >> it's some fun interaction ;( >> >> more staring at the assembly for me > > could you post the "bad" and the "good" disassembled functions, and the > specific gcc version string? > http://www.fenrus.org/memory.asm. ...

linux-kernel - Arjan van de Ven - Mar 5 2008 - 11:35

... more likely 32-bit case first. Ingo ------------------> Subject: x86: patches/x86-debug-bad-page.patch ... --- arch/x86/mm/pgtable_32.c | 7 +++++++ include/asm-x86/pgtable_32.h | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion ...

linux-kernel - Ingo Molnar - Mar 3 2008 - 05:13

On Mon, 3 Mar 2008, Arjan van de Ven wrote: > > interesting observation: if I turn the macros into inlines... the difference > goes away. > > I'm half tempted to just do it as inline period ... any objections ? Yes, I object. I want to

linux-kernel - Linus Torvalds - Mar 3 2008 - 14:44

> so (on 32-bit) ~_PAGE_PSE is ~0x80L is 0xffffff7f, which when cast to > 64-bit is 0x00000000ffffff7f, Actually, it is signed, so this isn't true. Comments about unsafeness still apply. Segher -- To unsubscribe from this list: send the

linux-kernel - Segher Boessenkool - Mar 3 2008 - 17:22

Linus Torvalds wrote: > > On Mon, 3 Mar 2008, Arjan van de Ven wrote: >> interesting observation: if I turn the macros into inlines... the difference >> goes away. >> >> I'm half tempted to just do it as inline period ... any objections ? > >

linux-kernel - Arjan van de Ven - Mar 3 2008 - 18:00

>> so (on 32-bit) ~_PAGE_PSE is ~0x80L is 0xffffff7f, which when cast to >> 64-bit is 0x00000000ffffff7f, > > Actually, it is signed, so this isn't true. Comments about unsafeness > still apply. It turns out that PAGE_SIZE is unsigned. So this

linux-kernel - Segher Boessenkool - Mar 3 2008 - 18:33

Segher Boessenkool wrote: >>> so (on 32-bit) ~_PAGE_PSE is ~0x80L is 0xffffff7f, which when cast to >>> 64-bit is 0x00000000ffffff7f, >> >> Actually, it is signed, so this isn't true. Comments about unsafeness >> still apply. > > It turns out

linux-kernel - H. Peter Anvin - Mar 3 2008 - 18:55

Segher Boessenkool wrote: >>> so (on 32-bit) ~_PAGE_PSE is ~0x80L is 0xffffff7f, which when cast to >>> 64-bit is 0x00000000ffffff7f, >> >> Actually, it is signed, so this isn't true. Comments about unsafeness >> still apply. > > It turns out that

linux-kernel - Jeremy Fitzhardinge - Mar 3 2008 - 18:56