... - } > } BTW, I certainly wouldn't inflict that on patches; at some point in series the body of if may shrink to one line only to get longer in the next patch. Removing and restoring {} would only add noise. OTOH, you've missed quite ...

linux-kernel - Al Viro - Mar 26 2008 - 06:48

... I certainly wouldn't inflict that on patches; at some point in > series the body ... only to get longer in the > next patch. Removing and restoring {} would only add noise ... because one never knows when a later patch gets delayed or dropped altogether. ] ...

linux-kernel - Ingo Molnar - Mar 26 2008 - 07:02

On Wed, 26 March 2008 10:48:21 +0000, Al Viro wrote: > > > -static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf, > > - loff_t to, size_t len, size_t *retlen) > > +static int > > +_block2mtd_write(struct block2mtd_dev *dev,

linux-kernel - Jörn - Mar 26 2008 - 06:57

* Al Viro wrote: > On Wed, Mar 26, 2008 at 11:14:52AM +0100, Ingo Molnar wrote: > > /* Info for the block device */ > > struct block2mtd_dev { > > - struct list_head list; > > - struct block_device *blkdev; > > -

linux-kernel - Ingo Molnar - Mar 26 2008 - 07:00

* Al Viro wrote: > > -static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf, > > - loff_t to, size_t len, size_t *retlen) > > +static int > > +_block2mtd_write(struct block2mtd_dev *dev, const u_char *

linux-kernel - Ingo Molnar - Mar 26 2008 - 07:10

On 03/26/2008 12:10 PM, Ingo Molnar wrote: > type > function_name(vars...) > { > > which tends to stay cleanly 2-line and looks tidier and shorter than > the: > > type function_name(vars... > more vars ...) > { > >

linux-kernel - Jiri Slaby - Mar 26 2008 - 07:14

On Wed, 2008-03-26 at 12:10 +0100, Ingo Molnar wrote: > not a "simple one-line function prototype" anymore, > so i use the same template for everything: > > type > function_name(vars ... > more vars ...) > { It seems the most

linux-kernel - Joe Perches - Mar 26 2008 - 12:30

... #Function_definitions No matter what coding style is, the winner is "linux-2.6/fs/xfs", and i doubt anyone can fix that :) Maybe meta-patching by `sed` scripts in `git`? Just kidding. -- -o--=O`C #oo'L O <___=E M -- To unsubscribe from this ...

linux-kernel - Oleg Verych - Mar 30 2008 - 00:29

On Sunday 2008-03-30 06:29, Oleg Verych wrote: > [] >>>> -static int block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len, >>>> +static int >>>> +block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len, >>>> size_t *retlen, const

linux-kernel - Jan Engelhardt - Mar 30 2008 - 01:31

Jan Engelhardt @ Sun, Mar 30, 2008 at 6:31 AM: > > No matter what coding style is, the winner is "linux-2.6/fs/xfs", and > > i doubt anyone can fix that :) > > They at least have an excuse of having a historical unix background :) i.e. zoo of

linux-kernel - Oleg Verych - Mar 30 2008 - 23:37