... way Unix traditionally does this, though. > > + */ > > +asmlinkage long sys_pipe(int __user *fildes) > > +{ > > + int fd[2]; > ... file descriptors leak if > copy_to_user fails? The MIPS implementation doesn't have this problem; it returns ...

linux-kernel - Ralf Baechle - May 5 2008 - 06:18

... 01 PM, Ulrich Drepper wrote: [...] > /* > + * sys_pipe() is the normal C calling standard for ... way Unix traditionally does this, though. > + */ > +asmlinkage long sys_pipe(int __user *fildes) > +{ > + int fd[2]; > ...

linux-kernel - DM - May 5 2008 - 04:30

... , Ulrich Drepper wrote: > [...] > > > /* > > + * sys_pipe() is the normal C calling standard ... traditionally does this, though. > > + */ > > +asmlinkage long sys_pipe(int __user *fildes) > > +{ > > + int fd[2] ...

linux-kernel - Michael Kerrisk - May 5 2008 - 05:15

... just mark the generic version with __weak? That way, odd architectures can just continue to call their own versions "sys_pipe()", and we don't break them unnecessarily. Linus -- To unsubscribe from this list: send the line "unsubscribe linux ...

linux-kernel - Linus Torvalds - May 3 2008 - 14:40