login
Header Space

 
 

Mailing list archives

Search results

Found 14 matching messages (0.164 seconds). Page 1 of 1.

Re: [PATCH] sched: missing locking in sched_domains code

... linux-2.6/include/linux/sched.h > @@ -809,6 +809,8 @@ struct sched_domain { > #endif > }; > > +extern struct mutex sched_domains_mutex; > + > ... It seems a bit fragile to take this lock in the caller without even adding a comment ...

linux-kernel - Andrew Morton - Apr 27 2008 - 21:39

Re: [PATCH] sched: missing locking in sched_domains code

... a bit fragile to take this lock in the caller without even ... a new lock :) Subject: [PATCH] sched: fix sched_domains locking From: Heiko ... lock_doms_cur(); - + mutex_lock(&sched_domains_mutex); + /* always unregister in case we don't destroy ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 03:09

Re: [PATCH] sched: missing locking in sched_domains code

... 's not conditional - an open > coded mutex_lock(&sched_doms_mutex) looks more readable ... is my order: Subject: [PATCH] sched: fix locking in arch_reinit_sched_domains From: ... got converted to get_online_cpus() the locking got broken. Unlike before now ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 04:49

Re: [PATCH] sched: missing locking in sched_domains code

... think it could be better :) Subject: [PATCH] sched: fix locking in arch_reinit_sched_domains From: Heiko ... deletions(-) Index: linux-2.6/kernel/sched.c =================================================================== --- linux-2.6.orig/kernel/ ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 05:17

Re: [PATCH] sched: missing locking in sched_domains code

... avoid (even more) confusion. Subject: [PATCH] sched: fix locking in arch_reinit_sched_domains From: Heiko ... deletions(-) Index: linux-2.6/kernel/sched.c =================================================================== --- linux-2.6.orig/kernel/ ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 05:33

Re: [PATCH] sched: missing locking in sched_domains code

Subject: [PATCH] sched: fix locking in arch_reinit_sched_domains From: Heiko Carstens sched.c =================================================================== --- linux-2.6.orig/kernel/ ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 04:11

Re: [PATCH] sched: missing locking in sched_domains code

... Partition sched domains as specified by the 'ndoms_new' > * cpumasks in the ... compares > * doms_new[] to the current sched domain partitioning, doms_cur[]. > @@ -7756,7 ... might be missing something but why not make doms_cur_mutex locking unconditional ...

linux-kernel - Ingo Molnar - Apr 28 2008 - 03:24

Re: [PATCH] sched: missing locking in sched_domains code

... @@ restart: > > > rebuild: > > > /* Have scheduler rebuild sched domains */ > > > get_online_cpus(); > > > + mutex_lock(&sched_domains_mutex); > > > partition_sched_domains(ndoms ... a bit fragile to take this lock in the caller without even adding ...

linux-kernel - Andrew Morton - Apr 28 2008 - 03:28

Re: [PATCH] sched: missing locking in sched_domains code

... @@ restart: > > > > rebuild: > > > > /* Have scheduler rebuild sched domains */ > > > > get_online_cpus(); > > > > + mutex_lock(&sched_domains_mutex); > > > > partition_sched_domains( ... a bit fragile to take this lock in the caller without even ...

linux-kernel - Heiko Carstens - Apr 28 2008 - 03:52

Re: [PATCH] sched: missing locking in sched_domains code

... ;) I forgot to add the lock in > sched_init_smp(). Not that it would ... avoid (even more) confusion. > > Subject: [PATCH] sched: fix locking in arch_reinit_sched_domains thanks Heiko ... send the line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Ingo Molnar - Apr 28 2008 - 08:27

Re: [PATCH] sched: missing locking in sched_domains code

... that it's not conditional - an open > > coded mutex_lock(&sched_doms_mutex) looks more readable - it ... refers to a no-longer-existing lock, and no longer correctly describes the lock ... : send the line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Andrew Morton - Apr 28 2008 - 04:57

Re: [PATCH] sched: missing locking in sched_domains code

... serializes calls to arch_init_sched_domains, > + * detach_destroy_domains and partition_sched_domains. > + */ locks protect *data*, not "calls". This matters. Which ... : send the line "unsubscribe linux-kernel" in the body of a message to majordomo@ ...

linux-kernel - Andrew Morton - Apr 28 2008 - 05:31

Re: [PATCH] sched: missing locking in sched_domains code

... lock_doms_cur() complication now that it's not conditional - an open coded mutex_lock(&sched_doms_mutex) looks more readable - it gives a ... from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org ...

linux-kernel - Ingo Molnar - Apr 28 2008 - 04:32

Re: [PATCH] sched: missing locking in sched_domains code

... > I don't believe this... version 43 ;) I forgot to add the lock in > sched_init_smp(). Not that it would really matter, but it should be > there ... list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Ingo Molnar - Apr 28 2008 - 09:13

speck-geostationary