... by to mean? > > jon > > > Reviewer's statement of oversight v0.01 > > By ... to code correctness leaving the subjective "worthwhile" statements are better expressed with ... good thing to have, although recruiting reviews remains an open issue. I ...

linux-kernel - Mark Gross - Oct 8 2007 - 14:40

... onto patches to document the oversight they had received on their ... the DCO for the Reviewed-by tag. To that end, I ... to mean? jon Reviewer's statement of oversight v0.01 By ... or the open source license(s) involved. - To unsubscribe from this ...

linux-kernel - Jonathan Corbet - Oct 8 2007 - 13:24

... /SubmittingPatches, for the precise meaning of + Signed-off-by. + +Acked-by: ... remaining serious technical issues. Any interested + reviewer (who has done the work) ... the person named. + + +---- + +Reviewer's statement of oversight, v0.02 + +By ...

linux-kernel - Jonathan Corbet - Oct 8 2007 - 18:43

... +Reviewed-by: The patch has been reviewed and found acceptible according acceptable > ... by the person named. > + > + > +---- > + > +Reviewer's statement of oversight, v0.02 > + > +By offering ...

linux-kernel - Randy Dunlap - Oct 8 2007 - 19:06

... /SubmittingPatches, for the precise meaning of > + Signed-off-by. Purpose: to ... credit to testers. > + > + > +---- > + > +Reviewer's statement of oversight, v0.02 > + > +By ... linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Neil Brown - Oct 8 2007 - 20:05

... : tag onto patches to document the oversight they had > received on their way ... -by to mean? > > jon > > > Reviewer's statement of oversight v0.01 > > By offering ... a short two line summery for each of them. Sam - To unsubscribe from this ...

linux-kernel - Sam Ravnborg - Oct 8 2007 - 13:37

... are licensed under the terms of the file modified. (Some people ... by: The patch has been reviewed and found acceptible according > > acceptable ... the Reviewer's Statement as found at the bottom of this ...

linux-kernel - Stephen Hemminger - Oct 8 2007 - 23:34

... threading part of screen being empty due to same subjects isn ... interesting stuff inside. And it's easy not only for mailing ... saw convincing statements about testing, i've placed review mark. Though ... linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Oleg Verych - Oct 8 2007 - 19:20

... a) I have carried out a technical review of this patch to evaluate its >> ... " Probably shouldn't be part of this. That's > what additional Signed off by ... to code correctness leaving the subjective "worthwhile" > statements are better expressed with other ...

linux-kernel - Stefan Richter - Oct 8 2007 - 14:53

... a) I have carried out a technical review of this patch to evaluate its > ... to code correctness leaving the subjective "worthwhile" > > statements are better expressed with other ... > criterion. Yes, but there's also such thing as "worthwhile removal". - ...

linux-kernel - Al Viro - Oct 8 2007 - 15:05

... would". --- > + > + (d) While I have reviewed the patch and believe it ... to make such a statement, regardless of qualification. --- > + (unless explicitly stated ... or > + the open source license(s) involved. --- (e) seems over-careful ...

linux-kernel - Scott Preece - Oct 10 2007 - 09:40

... useful than others While a review by a trustworthy person is ... discourage people from reviewing. A new reviewer's review may not ... on the existing (small) trusted reviewer base, but the hope is ... linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Jeremy Fitzhardinge - Oct 8 2007 - 14:01

... I don't generally object to the idea of the > patch, but may not have read ... be ugly as sin but it works... > >> Reviewed-by: > >> > > > > * I am maintaner or an ' ... to > discourage people from reviewing. A new reviewer's review may not be > ...

linux-kernel - Randy Dunlap - Oct 8 2007 - 14:06

... the authority of the person acking, > reviewing, testing, or nacking. That's only ... is pretty clearly not getting adequately reviewed, or where someone is obviously abusing ... too complicated unless we know it's necessary. Premature complexity is almost as ...

linux-kernel - Theodore Tso - Oct 8 2007 - 17:38

... the authority of the person acking, > > reviewing, testing, or nacking. That's only ... is pretty clearly not getting adequately > reviewed, or where someone is obviously abusing ... complicated > unless we know it's necessary. Premature complexity is almost ...

linux-kernel - Rafael J. Wysocki - Oct 8 2007 - 18:18

... it should really imply that issues of interest have been > communicated to ... (our internal SCM records the reviewer(s) and the git export script converts that to s-o-b). It would be ... if they were exported as Reviewed-by under your definition.... IOWs, ...

linux-kernel - David Chinner - Oct 9 2007 - 20:06

... )like/experience with the > patch. > > >Reviewed-by: > > * I am maintaner or ... point - the assigning of weight to the Reviewer's opinion is ... the top of the merge process and there's no need ... this patch after a thorough review", and either can be attached ...

linux-kernel - Scott Preece - Oct 8 2007 - 15:35

... prefer to leave an explicit mention of > > communication in there. > > I couldn't ... , and I review it, and I find a couple of problems, do I need to negotiate ... is relevant to the general health of the community). NeilBrown - To unsubscribe from ...

linux-kernel - Neil Brown - Oct 14 2007 - 20:27

... don't generally object to the idea of the >> patch, but may not have read ... didn't explode" - >> that's on par with an actual review (ideally all patches would be both >> ... "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org ...

linux-kernel - Stefan Richter - Oct 8 2007 - 14:34

... supply a Reviewed-by: tag no matter who they are. Of course the ... at this patch in depth." Jon's text seems like a really good summation of that idea in more explicit language ... unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel ...

linux-kernel - Roland Dreier - Oct 8 2007 - 14:40