... preemptible BKL feature and made the Big Kernel Lock a spinlock ... core kernel In other words: the kill-the-BKL tree turns ... int rpc_wait_bit_killable(void *word) { + int bkl = kernel_locked(); + if (fatal_signal_pending(current)) return ...

linux-kernel - Ingo Molnar - May 14 2008 - 13:49

... inside subsystems, so do inner locks vanish from its scope - and ... on the list */ spin_lock(&sb_lock); if (__put_super_and_need_restart(sb)) -------------> Subject: remove bkl: ... a message to majordomo@vger.kernel.org More majordomo info at ...

linux-kernel - Ingo Molnar - May 14 2008 - 15:41

... no longer even take the kernel lock any more. yeah. And ... remainder we had from incorrect BKL elimination were subtle breakages. And ... will of course remain in the upstream scheduler until we are ... stability of this whole kill-the-BKL approach) I'm sure ...

linux-kernel - Ingo Molnar - May 15 2008 - 04:02

... preemptible BKL feature and made the Big Kernel Lock a > spinlock ... considered doing this work in tree instead? As in just add ... more users this way and the work would go faster. It ... g. let ISDN continue using BKL forever. -Andi -- To unsubscribe from ...

linux-kernel - Andi Kleen - May 14 2008 - 14:30

... regardless of depth. That makes the code more generic, but it ... to staple themselves to something big and fast moving. > By having ... that the BKL turns into something that resembles a normal lock ... a message to majordomo@vger.kernel.org More majordomo info at ...

linux-kernel - Peter Zijlstra - May 15 2008 - 16:45

... int rpc_wait_bit_killable(void *word) > { > + int bkl = kernel_locked(); > + > if (fatal_signal_pending(current)) > return ... with the kernel locked in the first place. The BKL doesn ... a message to majordomo@vger.kernel.org More majordomo info at ...

linux-kernel - Linus Torvalds - May 15 2008 - 13:41

... that BKL > > using code can use to staple themselves to something big and ... it possible to have inverse lock order and not > deadlock. I ... the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at ...

linux-kernel - Arjan van de Ven - May 15 2008 - 17:22

... just a > single level of locking, and is ugly to boot. ... more readable than that "if (bkl) [un]lock_kernel()" > sequence. can we ... BKL using code can use to staple themselves to something big ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Arjan van de Ven - May 15 2008 - 16:27

... locking on other code - eg the ISN > > use of the BKL ... just stick unlock_kernel()/lock_kernel() around the call > to TTY (or similar ... a message to majordomo@vger.kernel.org More majordomo info at ... majordomo-info.html Please read the FAQ at http://www.tux ...

linux-kernel - Alan Cox - May 14 2008 - 17:19

... to external module maintainers that the change needs > to be made ... any of them actually > *need* the BKL, something awful may happen ... follow big discussions like this) can just take the kernel lock ... majordomo-info.html Please read the FAQ at http://www.tux ...

linux-kernel - Linus Torvalds - May 14 2008 - 18:14

... could add an unlocked_open() to the file_operations structure; > drivers could be ... calls already don't need the BKL. > But it's a ... a .locked_open and move all BKL-requiring code to use that ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Jan Engelhardt - May 15 2008 - 04:44

... being to get rid of BKL in old drivers, but not ... in new drivers. Basically all BKL assumptions > in interfaces really should ... too. Or at least in the interfaces. Linus -- To unsubscribe from ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Linus Torvalds - May 14 2008 - 18:16

... add a .locked_open and move all BKL-requiring code to use that. > ... the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http ... org/majordomo-info.html Please read the FAQ at http://www.tux.org ...

linux-kernel - Diego Calleja - May 15 2008 - 10:54

... being to get rid of BKL in old drivers, but not ... in new drivers. Basically all BKL assumptions >>>> in interfaces really should ... lock_kernel calls, but why in the old drivers? For > Andi> those ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Andi Kleen - May 15 2008 - 11:10

... being to get rid of BKL in old drivers, but not ... in new drivers. Basically all BKL assumptions >>>>> in interfaces really should ... CPU counts. True, but with the growing number of multicore systems ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - John Stoffel - May 15 2008 - 11:18

... I decided to give this tree a try, and I got: ... from GDB that: vfs_ioctl locks the kernel before calling drm_ioctl, and, ... procfs code previously using the BKL in the dir-entry manipulation ... a message to majordomo@vger.kernel.org More majordomo info at ...

linux-kernel - Kevin Winchester - May 16 2008 - 20:37

... using BKL forever. >> Most > > Most? > >> of the legacy users inflict that locking on ... So you just stick unlock_kernel()/lock_kernel() around the call > to TTY (or similar to ... of a message to majordomo@vger.kernel.org More majordomo info at http ...

linux-kernel - H. Peter Anvin - May 14 2008 - 17:16

... we still have 1300+ legacy BKL using sites. There are 400+ ... could add an unlocked_open() to the file_operations structure; drivers could be ... missed. I kind of like the combination of 2 and 3 ... line "unsubscribe linux-kernel" in the body of a message to ...

linux-kernel - Jonathan Corbet - May 14 2008 - 17:45

... "magic" accidental, undocumented and pot luck BKL locking semantics > between subsystems that are ... core modules no longer even take the kernel lock any more. In the ... anyway if they did). - default_llseek(). Probably the same, just a lot less of ...

linux-kernel - Linus Torvalds - May 14 2008 - 17:45

... luck BKL locking semantics >> between subsystems that are not even visible. > > The good ... anyway if they did). > > - default_llseek(). Probably the same, just a lot less of it ... of a message to majordomo@vger.kernel.org More majordomo info at http ...

linux-kernel - Andi Kleen - May 14 2008 - 18:03