From: Alan Stern This patch (as991) updates the unusual_devs entry for the Nokia 6131 phone. As reported by Juan Ignacio Cherrutti, there's new firmware available but it still has the same old transfer-size limit. ...

linux-usb-devel - Greg Kroah-Hartman - Oct 12 2007 - 18:18

... cut down the review noise for the > patch in question last time it happened. ok ... arch/sparc64/kernel/cpu.c 17 155 109.6 arch/sparc64/solaris/ipc.c ... no need for any annoying "monkey patches". or take a look at the ...

linux-kernel - Ingo Molnar - Mar 25 2008 - 09:17

... \$chk_signoff, - 'patch!' => \$chk_patch, - 'emacs!' => \$emacs, - 'terse!' => \$terse, - 'file!' => \$file, - 'subjective!' => \$check, ... - if ($filename eq '-') { - $vname = 'Your patch'; - } else { - $vname = $filename; - } - while () ...

linux-kernel - Al Viro - Mar 23 2008 - 04:52

... t result in crap) rather > than 148 patches of checkpatch vomit. Joe should not ... out unnecessary visual noise when reviewing patches and writing code, but i prefer to ... state, the flow of "explicit" checkpatch patches comes to a virtual standstill - ...

linux-kernel - Ingo Molnar - Mar 25 2008 - 06:48

... " argument =B-) > > When you reject useful patches based on "this is not our preferred ... i ask the person to send future patches with that small detail fixed.) my ... old-timer who sent absolutely horrible patches and who _should have known better_. ...

linux-kernel - Ingo Molnar - Mar 25 2008 - 10:03

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches diff --git a/MAINTAINERS b/MAINTAINERS index ac9cded..a341fc0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1066,6 +1066,7 @@ BLUETOOTH HCI BTUART DRIVER P:

linux-kernel - joe - Aug 13 2007 - 02:24

From: Oliver Neukum use anchors in disconnect handling Signed-off-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usb-skeleton.c | 2 ++ 1 files changed, 2 insertions

linux-usb-devel - Greg Kroah-Hartman - Jul 12 2007 - 19:42

Stop using kobject_register, as this way we can control the sending of the uevent properly, after everything is properly initialized. Cc: Steven Whitehouse Cc: Kay Sievers Signed-off-by: Greg Kroah-

linux-kernel - Greg Kroah-Hartman - Jan 25 2008 - 03:32

Signed-off-by: Joe Perches --- include/asm-x86/serial.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-x86/serial.h b/include/asm-x86/serial.h index 628c801..ae8370f 100644 --- a/include/

linux-kernel - Joe Perches - Mar 23 2008 - 04:03

... > > > Signed-off-by: Joe Perches > > An obvious corollary to this highly inspired series of patches: Acked-by: David S. Miller I totally agree, checkpatch is just shit. -- To unsubscribe from this list: ...

linux-kernel - David Miller - Mar 23 2008 - 06:20

... Perches wrote: >>> Signed-off-by: Joe Perches >> An obvious corollary to this highly inspired series of patches: > > Acked-by: David S. Miller > > I totally agree, checkpatch is just shit. I disagree. It' ...

linux-kernel - Jiri Slaby - Mar 23 2008 - 08:06

... >> An obvious corollary to this highly inspired series of patches: > > > > Acked-by: David S. Miller > ... work doesn't result in crap) rather than 148 patches of checkpatch vomit. Fixing sparse warnings properly fixes real issues ...

linux-kernel - David Miller - Mar 23 2008 - 08:19

... checkpatch work doesn't result in crap) rather > than 148 patches of checkpatch vomit. > > Fixing sparse warnings properly fixes real issues ... It may help track down some issues in yet prepared patch (it's checkpatch, not checkcode and it should be used ...

linux-kernel - Jiri Slaby - Mar 23 2008 - 08:24

... checkpatch work doesn't result in crap) rather > > than 148 patches of checkpatch vomit. > > > > Fixing sparse warnings properly fixes real ... It may help track down some issues > in yet prepared patch (it's checkpatch, not checkcode and it should be ...

linux-kernel - David Miller - Mar 23 2008 - 08:30

* David Miller wrote: > I strongly disagree still. > > Half the warnings I get when I have run checkpatch on things I've > written were crap. could you please give me a file name as an example that i could double-check

linux-kernel - Ingo Molnar - Mar 25 2008 - 04:44

... t because I pacified it to cut down the review noise for the patch in question last time it happened. I can tell you one more ... newbies, treat it as gospel and a way to contribe "useful" patches. They aren't useful, they're crap. Fix a bug instead of ...

linux-kernel - David Miller - Mar 25 2008 - 05:42

... be doing it for all actively > maintained areas of the kernel? Disagreement between checkpatch and maintainers preferred style. I've had a patch that fixed a bug and - while in the region - "cleaned up" the style for a single line. This line no ...

linux-kernel - Jörn - Mar 25 2008 - 07:11

... and maintainers preferred style. I've > had a patch that fixed a bug and - while in the ... you do, there is no > disagreement to deal with. :) note, all those patches are "Subject: x86: " and 99% of them is maintained by us x86 maintainers. Ingo ...

linux-kernel - Ingo Molnar - Mar 25 2008 - 08:24

Ingo Molnar writes: > > On a more conceptual angle: "coding style", despite being entirely > "non-functional" (it does not affect the generated code), is still very > much an integral part of the code because source code is

linux-kernel - Andi Kleen - Mar 25 2008 - 08:26

... even see that warning unless you very explicitly do: checkpatch.pl --subjective Secondly, even about this "checkpatch.pl --subjective" check you are wrong. As someone who had to decode (way!) too many ...

linux-kernel - Ingo Molnar - Mar 25 2008 - 09:05