priv->param_workaround_interval is unsigned, modparam_workaround_interval not. the former is never < 0. Signed- ... diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/ ... ..d0b1fb1 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/ ...

linux-kernel - Roel Kluin - Apr 23 2008 - 16:10

... >: > priv->param_workaround_interval is unsigned, > modparam_workaround_interval not. > the former is never < 0. > > Signed-off-by: ... index 977751f..d0b1fb1 100644 > --- a/drivers/net/wireless/rndis_wlan.c > +++ b/drivers/net/wireless/rndis_wlan. ...

linux-kernel - Jussi Kivilinna - Apr 24 2008 - 02:16

... not. > the former is never < 0. > - priv->param_workaround_interval =3D modparam_workaround_interval; > =20 > - if (priv-> ... =3D 500; > + else > + priv->param_workaround_interval =3D modparam_workaround_interval; Eh, why not make the modparam ...

linux-kernel - Johannes Berg - Apr 24 2008 - 04:57

... it, that would be better option. The modparam already has default value of 500. Reason why workaround modparam is signed, is that value -1 did have some functionality in some early version. That then changed and priv->param_workaround_interval ...

linux-kernel - Jussi Kivilinna - Apr 24 2008 - 05:26

... 500. > > Reason why workaround modparam is signed, is that value -1 did have some ... unsigned and forgot about > modparam. I merged the patch, so if you want that behavior we need a new patch. John -- John W. Linville linville@tuxdriver.com ...

linux-kernel - John W. Linville - Apr 24 2008 - 08:16