... is no need for a BKL in ivtv or cx18. It ... d like to know, otherwise the BKL can be removed altogether ... suspect you just pushed the lock down into the driver and ... list > Unsubscribe > mailto:video4linux-list-request@redhat.com?subject=unsubscribe > https ...

linux-kernel - Hans Verkuil - May 23 2008 - 02:16

... update it and it becomes the unlocked_ioctl method. Older drivers > > > use ... d like to know, otherwise the BKL can be removed > altogether ... course you just pushed down the lock, the subject said so ... majordomo-info.html Please read the FAQ at http://www.tux ...

linux-kernel - Hans Verkuil - May 23 2008 - 02:28

... painful as > all hell, given the massive number of callbacks in ... be safe in the absence of the > BKL. The amount of ... part of the changes. Pushing it down to the video2_ioctl is a ... unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...

linux-kernel - Alan Cox - May 23 2008 - 11:39

... Chehab wrote: > > > Since the other methods don't explicitly call BKL ... 6.26 and prior kernels *do* acquire the BKL on open (for > char devices) ... So, for example, I've pushed that acquisition down > into video_open() instead. ...

linux-kernel - Mauro Carvalho Chehab - May 27 2008 - 14:59

... Chehab wrote: > > > > > Since the other methods don't explicitly call ... .26 and prior kernels *do* acquire the BKL on open (for > > char devices) ... So, for example, I've pushed that > > acquisition down into video_open() instead. ...

linux-kernel - Arjan van de Ven - May 27 2008 - 15:50

... wrote: > > > > > > > Since the other methods don't explicitly call ... .26 and prior kernels *do* acquire the BKL on open (for > > > char devices) ... So, for example, I've pushed that > > > acquisition down into video_open() instead. ...

linux-kernel - Mauro Carvalho Chehab - May 27 2008 - 16:24

... mchehab@infradead.org> wrote: > Since the other methods don't explicitly ... and prior kernels *do* acquire the BKL on open (for char ... for example, I've pushed that acquisition down into video_open() instead ... As soon as you take the BKL out of ioctl(), though ...

linux-kernel - Jonathan Corbet - May 27 2008 - 12:37

... alan@lxorguk.ukuu.org.uk> wrote: > The problem is that currently they ... part of the changes. Pushing it down to the video2_ioctl is a ... Right now we've gone from BKL buried in fs to ... unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...

linux-kernel - Jonathan Corbet - May 23 2008 - 12:09

... to video_usercopy_unlocked() without that. > > In the specific case of ivtv and ... Douglas already did an experimental patch converting ivtv to > video_ioctl2 and ... Could you send this patch to the ML for people to ... I can move the BKL down at the same time for ...

linux-kernel - Hans Verkuil - May 26 2008 - 12:46

... (inode, file, cmd, parg); > + unlock_kernel(); This forces the BKL on all V4L2 drivers whether or not ... , and it would let safe drivers operate BKL-free. jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of ...

linux-kernel - Jonathan Corbet - May 23 2008 - 09:56

... devices, when switching mode. > > On the other hand, some userspace apps, ... (&fepriv->sem)) > return -ERESTARTSYS; > > [1] The code can be more conservative, ... list > Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe > https ...

linux-kernel - Andy Walls - May 27 2008 - 19:48

... The pvrusb2 driver already should not require the BKL. Though since this driver (like ... to the overall issue here in pushing the lock down into video_usercopy(). In the mean ... the pvrusb2 portion of this patch... Acked-By: Mike Isely ...

linux-kernel - Mike Isely - May 25 2008 - 19:46

... > > update it and it becomes the unlocked_ioctl method. Older drivers > > > use the ... out the changes to eliminate the BKL from > > cx18. > > > > Could someone give me a ... I'm assuming it's not the > > mutex_un/lock(&....->serialize_lock) and that the ...

linux-kernel - Mauro Carvalho Chehab - May 26 2008 - 12:39

... I'm assuming it's not the > mutex_un/lock(&....->serialize_lock) and that the ... the lock. video_usercopy currently also uses the BKL so you might want to ... : Setting file flags and using the deprecated sleep_on and interruptible_sleep_on. Other things ...

linux-kernel - Alan Cox - May 23 2008 - 05:09

... version to video_usercopy_unlocked() without that. In the specific case of ivtv and ... it first to video_ioctl2. Then, remove the BKL, with a video_ioctl2_unlocked version. Douglas already did an experimental patch converting ivtv to video_ioctl2 and ...

linux-kernel - Mauro Carvalho Chehab - May 26 2008 - 12:34

... a few special cases. I liked the patch also. Still, it didn't ... add a video_ioctl2_unlocked() function, without BKL (and keeping BKL explicit locks at ... or VIDIOC_TRY ones. Cheers, Mauro. --- patching file drivers/media/video/bt8xx/bttv ...

linux-kernel - Mauro Carvalho Chehab - May 26 2008 - 12:59

... are also currently done > under the BKL. True, but on a ... interrupting program 1 execution in the middle of a data initialization ... True. Yet, just looking at the code may not be enough, ... videobuf lock showed this. The lock fix patches caused several new ...

linux-kernel - Mauro Carvalho Chehab - May 27 2008 - 12:31

... 'd be in favour of actually patching ->ioctl out of the bkl-removal tree and letting people fix the other architectures by neccessity ;) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of ...

linux-kernel - Alan Cox - May 23 2008 - 14:58

... better. I didn't analyze his patch in detail. However, it is a ... > I can move the BKL down at the same time for ivtv ... do that easily based on the ivtv changes. This strategy seems ... unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...

linux-kernel - Mauro Carvalho Chehab - May 26 2008 - 17:14

... update it > and it becomes the unlocked_ioctl method. Older drivers use ... so we make it do the work. Finally there are a ... changes to eliminate the BKL from cx18. Could someone give me ... unsubscribe from this list: send the line "unsubscribe linux-kernel" in ...

linux-kernel - Andy Walls - May 22 2008 - 22:08