... Whitcroft wrote: > This version brings a number of new checks ... #221: FILE: scripts/checkpatch.pl:635: + if ($level == 0 && $ctx =~ /\)\s*\; ... malloc/mallocnocast.html\n" . $herecurr); Your patch has style problems, please review. ...

linux-kernel - Ingo Molnar - Sep 28 2007 - 04:40

... an update wrt. the latest checkpatch.pl-next version (v11-to- ... is a false positive! So v11-to-be gets the "best ... and it would be cleaner to use 'struct ctl_table' thoughout the ... think.) nice work Andy! Ingo - To unsubscribe from this list: send ...

linux-kernel - Ingo Molnar - Oct 5 2007 - 01:56

... casts for kalloc() Andy Whitcroft (18): Version: 0.10 asmlinkage is also a storage type ... -by: Andy Whitcroft --- scripts/checkpatch.pl | 254 +++++++++++++++++++++++++++++++++++++----------- 1 files changed, 196 ...

linux-kernel - Andy Whitcroft - Sep 12 2007 - 11:00

... is simply not > achieveable. you _still_ fail to understand (let alone address), the fundamental ... much of it, the most usable checkpatch.pl version was v6/v7. It went ... as a mandatory component of their patch-toolchain here and today. But your ...

linux-kernel - Ingo Molnar - Sep 28 2007 - 06:49

... it, > > the most usable checkpatch.pl version was v6/v7. It ... be. How hard is that to understand?? Having zero (or near ... a mandatory component of their > patch-toolchain here and today. But ... option which controls the more subjective tests which will be in ...

linux-kernel - Andy Whitcroft - Sep 28 2007 - 09:21

... wrote: > > > >Maybe checkpatch.pl needs an option '-W' to turn on/ ... that's the root problem. checkpatch is a regex tool, not ... 's just a guide. --- ~Randy - To unsubscribe from this list: send ... the body of a message to majordomo@vger.kernel.org More ...

linux-kernel - Randy Dunlap - Sep 28 2007 - 12:57

... wrote: > > > This version brings a number of new ... since v8 the quality of > checkpatch.pl has been getting worse ... 'd types. I am working to make it better. However, the ... I for one send out patches with style violations where I ...

linux-kernel - Andy Whitcroft - Sep 28 2007 - 05:52

... WANG Cong wrote: > >Maybe checkpatch.pl needs an option '-W' to turn on/off those ... the whitespace violations without false positives. :-) - To unsubscribe from this list: send the ... " in the body of a message to majordomo@vger.kernel.org More majordomo ...

linux-kernel - Jan Engelhardt - Sep 28 2007 - 10:19

... advanced mode: >- I want to be able to see as many ... for git and mail traffic > >checkpatch in safe mode: >- I never ... traffic > Maybe checkpatch.pl needs an option '-W' to turn on ... take such a retrograde step." - To unsubscribe from this list: send ...

linux-kernel - WANG Cong - Sep 28 2007 - 07:03

... > > interested in borderline or hard to judge warnings too, but these > > ... put it this way: checkpatch in advanced mode: - I want to be able to see as many possible ... for git and mail traffic Christian - To unsubscribe from this list: send the ...

linux-kernel - Christian Borntraeger - Sep 28 2007 - 06:46

... : > On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar patches which later alter that code. A bit. I tend to agree, watching the automatic replies from checkpatch, the majority of these are "justifiable" ...

linux-kernel - Andy Whitcroft - Sep 28 2007 - 05:22

... it. The original purpose was to catch the most tivial coding ... would be much preferable to have a checkpatch - and that may ... too much noise so a patch-bot usage is not possible. ... leave the default simple. Sam - To unsubscribe from this list: send ...

linux-kernel - Sam Ravnborg - Sep 28 2007 - 12:51

... #2319: > > > + max_load = this_load = total_load = total_pwr = 0; > > > > That warning is non-bogus, ... of the code, and > > from patches which later alter that code. ... > I tend to agree, watching the automatic replies from checkpatch, the ...

linux-kernel - Ingo Molnar - Sep 28 2007 - 05:39

... alter that code. A bit. > > > > I tend to agree, watching the automatic replies from checkpatch, the > ... of having a 'perfectly clean' file/patch. > > And this is not about any ... to run 0.1 as that didn't check anything. v9 and 10 carry checks ...

linux-kernel - Andy Whitcroft - Sep 28 2007 - 06:00

... run across the whole kernel to find out, his estimation is ... automated checks of every patch posted to lkml and I work ... which drive my development effort. checkpatch is a work in progress ... years to come. I have propose we 'gate' those subjective tests ...

linux-kernel - Andy Whitcroft - Sep 28 2007 - 10:02

On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar #2319: > + max_load = this_load = total_load = total_pwr = 0; That warning is non-bogus, although ... , and from patches which later alter that code. A bit. - To unsubscribe from this ...

linux-kernel - Andrew Morton - Sep 28 2007 - 05:01

... : > On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar > reported to you earlier: > > > > WARNING: multiple assignments should be ... the readability of the code, and from > patches which later alter that code. A ...

linux-kernel - Ingo Molnar - Sep 28 2007 - 05:44

... . I would love the tests to > be 100% accurate, but if I ... have none. There is a balance to be struck and we > have ... strict or similar command line option? - To unsubscribe from this list: send ... the body of a message to majordomo@vger.kernel.org More ...

linux-kernel - Pekka Enberg - Sep 28 2007 - 09:37

... is whether this should default to on. You are voting > off ... very high ratio of hits to false positives, but would still ... number of false positives. -Joel - To unsubscribe from this list: send ... the body of a message to majordomo@vger.kernel.org More ...

linux-kernel - Joel Schopp - Sep 28 2007 - 11:50

... /--no-check option which controls > the more subjective tests which will be in the next ... only question is whether this should default to on. You are voting > off. I personally ... " in the body of a message to majordomo@vger.kernel.org More majordomo info ...

linux-kernel - Randy Dunlap - Sep 28 2007 - 13:26