... in these functions, so checking for null here seems a bit unnecessary. Signed- ... --- drivers/char/riscom8.c | 4 ++-- 1 files changed, ... index f073c71..9643a49 100644 --- a/drivers/char/riscom8.c +++ b/drivers/char/riscom8 ...

linux-kernel - Chris Malley - May 12 2008 - 14:27

... Chris Malley wrote: > tty has already been dereferenced at least twice in these functions, > so checking for null here seems a bit unnecessary. Oh it is - and lots of the other tty checks are bogus too. Acked-by: Alan Cox ...

linux-kernel - Alan Cox - May 12 2008 - 15:58