... :58 AM, Jianjun Kong wrote: > Standard indentation of arguments. > I use right blank ... table, in order to make the arguments alining. For example: > > old: > extern void ... on this. I personally do prefer indentation by tabs. -- To unsubscribe from this ...

linux-kernel - Jiri Slaby - May 21 2008 - 03:19

... 07:58 AM, Jianjun Kong wrote: >> Standard indentation of arguments. >> I use right blank space ... table, in order to make >> the arguments alining. > > I think, there is no " ... pales compared to how annoying I find patches that can best be described as ...

linux-kernel - David Newall - May 21 2008 - 07:35

Standard indentation of arguments. I use right blank space to displace the ... table, in order to make the arguments alining. For example: old: extern void ... (struct list_head *list, * @head: the head of the list */ static inline int list_is_last( ...

linux-kernel - Jianjun Kong - May 21 2008 - 01:58

... and completely unrelated to any kind of kernel development) misposted on linux-kernel ... separate list dedicated to this kind of self-gratification would hopefully * reduce the ... +0800, Jianjun Kong wrote: > Standard indentation of arguments. > I use right ...

linux-kernel - Al Viro - May 21 2008 - 04:34

... to at least enforce very basic standards a lot of > | > > the crap shoved in doesn' ... From: Johannes Weiner Subject: [PATCH] CodingStyle: no more trivial coding ... +But do not send patches that fix indentation of two lines. It is ...

linux-kernel - Johannes Weiner - May 21 2008 - 15:42

... to at least enforce very basic standards a lot of | > | > > the crap shoved in doesn' ... From: Johannes Weiner | Subject: [PATCH] CodingStyle: no more trivial coding ... +But do not send patches that fix indentation of two lines. It is ...

linux-kernel - Cyrill Gorcunov - May 21 2008 - 15:47

... serious code due to an alignment patch >> getting a cynical slapdown. > > Well you ... this will make others fear the consequences of > any mistake they might make. I ... everyone is going to appreciate argument alignment patches. So I'll not submit ...

linux-kernel - Rene Herman - May 21 2008 - 17:32

... for himself and a lack of expressed > disagrement from others should ... least enforce very basic standards a lot of the crap shoved in doesn't follow instead of wanking around about exact placement ... linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Christoph Hellwig - May 21 2008 - 06:32

... for himself and a lack of expressed > > disagrement from others should ... least enforce very basic standards a lot of > the crap shoved ... graduate to writing real, useful patches. If they won't, there ... linux-kernel" in the body of a message to majordomo@vger ...

linux-kernel - Theodore Tso - May 21 2008 - 08:09

... speaks only for himself and a lack of expressed > > > disagrement from others should not be ... to at least enforce very basic standards a lot of > > the crap shoved in doesn ... comments will graduate to writing real, useful > patches. If they won't, there's no ...

linux-kernel - Andrew Morton - May 21 2008 - 13:46

... speaks only for himself and a lack of expressed | > > > disagrement from others should not be ... to at least enforce very basic standards a lot of | > > the crap shoved in doesn ... will graduate to writing real, useful | > patches. If they won't, there's no ...

linux-kernel - Cyrill Gorcunov - May 21 2008 - 14:57

... speaks only for himself and a lack of expressed > | > > > disagrement from others should not be ... to at least enforce very basic standards a lot of > | > > the crap shoved in ... will graduate to writing real, useful > | > patches. If they won't, there's no ...

linux-kernel - Randy Dunlap - May 21 2008 - 15:33

... speaks only for himself and a lack of expressed | > | > > > disagrement from others should not ... at least enforce very basic standards a lot of | > | > > the crap shoved in ... will graduate to writing real, useful | > | > patches. If they won't, there's ...

linux-kernel - Cyrill Gorcunov - May 21 2008 - 15:45

... find things which need fixing. > Often simple little things like compilation errors, sometimes things > which need a bisection search. Some of us never manage to escape from that level. I dug around, and I've been playing the "What did -mm break ...

linux-kernel - Valdis.Kletnieks - May 21 2008 - 17:08

... will be directly proportional to the vehemence of the original posting. That applies to all ... not worth the > effort and your patch is likely to be rejected. Fixing ... references to removed or renamed > functions/arguments etc is, however, useful and worth ...

linux-kernel - Al Viro - May 21 2008 - 20:14

... be directly > proportional to the vehemence of the original posting. That applies to all ... not worth the >> effort and your patch is likely to be rejected. Fixing ... references to removed or renamed >> functions/arguments etc is, however, useful and worth ...

linux-kernel - Jesper Juhl - May 21 2008 - 20:34

... > serious code due to an alignment patch getting a cynical slapdown. Well you should ... this will make others fear the consequences of any mistake they might make. This could ... "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel. ...

linux-kernel - Andrew Morton - May 21 2008 - 17:12

... not worth the > effort and your patch is likely to be rejected... [ ... . Jesper, I think that part of text (what to stay away from ... would read this document before sending patch but we will be able ... linux-kernel" in the body of a message to majordomo@vger. ...

linux-kernel - Cyrill Gorcunov - May 22 2008 - 00:51

... > like the real-time properties of the kernel, then the experimental - ... not the -tr tree > If your patch did not get applied and you ... or some > criticism about your patch, then your job is easy. ... linux-kernel" in the body of a message to majordomo@vger. ...

linux-kernel - david - May 22 2008 - 01:34