... to improve netconsole/netpoll support on RTL8139 NIC driver. Signed-off ... In current RTL8139 NIC driver, spin_lock()/spin_unlock() is used >> for irq ... prefers >> spin_lock_irqsave()/spin_unlcok_irqrestore(). So this patch fixed >> this problem to improve ...

linux-kernel - yshi - Mar 25 2008 - 22:38

... > In current RTL8139 NIC driver, spin_lock()/spin_unlock() is used > for irq ... So this patch fixed > this problem to improve netconsole/netpoll support. > > Signed-off ... the burden on the netpoll/netconsole layer. Jeff -- To unsubscribe from ...

linux-kernel - Jeff Garzik - Mar 25 2008 - 22:23

In current RTL8139 NIC driver, spin_lock()/spin_unlock() is used for irq handler. But for ... /netpoll, it prefers spin_lock_irqsave()/spin_unlcok_irqrestore(). So this patch fixed this problem to improve netconsole/netpoll support. Signed-off-by: Yang ...

linux-kernel - yshi - Mar 25 2008 - 22:12

... /cli. > > I would in fact prefer to see drivers unconditionally use > spin_lock_irqsave() et al. in the interrupt handler, for > consistency. > Yes, I agree. Many NIC drivers do the same thing, like ...

linux-kernel - yshi - Mar 25 2008 - 22:52

... /cli. >> >> I would in fact prefer to see drivers unconditionally use >> spin_lock_irqsave() et al. in the interrupt handler, for >> consistency. >> > Yes, I agree. Many NIC drivers do the same thing, like Gianfar, ...

linux-kernel - Jeff Garzik - Mar 25 2008 - 23:14

... a larger interrupt handler... more CPU instructions for the >> same result. > > Jeff, please be realistic ... applying this consistency rule across N drivers needlessly increases the code size of N drivers. Mainly I see such a change as a violation ...

linux-kernel - Jeff Garzik - Mar 25 2008 - 23:39

... as a plain sti/cli. I would in fact prefer to see drivers unconditionally use spin_lock_irqsave() et al. in the interrupt handler, for consistency. -- To unsubscribe from this list: send the line "unsubscribe linux- ...

linux-kernel - David Miller - Mar 25 2008 - 22:42

... in a larger interrupt handler... more CPU instructions for the same result. > I would in fact ... to see drivers unconditionally use > spin_lock_irqsave() et al. in the interrupt handler, for > consistency. The entire spin_lock() apparatus in the ...

linux-kernel - Jeff Garzik - Mar 25 2008 - 23:14

... wonder if using spin_lock_irqsave() makes moving to a real-time kernel with interrupt threads more difficult for that driver. And of course we're talking about a hot path here. Jeff -- To unsubscribe from ...

linux-kernel - Jeff Garzik - Mar 25 2008 - 23:48

... makes moving to a real-time > kernel with interrupt threads more difficult for that driver. > > And of course we're talking about a hot path here. First, ... t matter, at all. Again, you're arguing for 18 cycles or so out of say 800 ...

linux-kernel - David Miller - Mar 25 2008 - 23:53

... > at all. > > Again, you're arguing for 18 cycles or so out of ... negative effects of doing needless work for the sake of consistency: * eliminates ability to ... license to add needless code to drivers? No, again, IMO. Jeff -- To unsubscribe ...

linux-kernel - Jeff Garzik - Mar 26 2008 - 00:32

... Replacing spin_lock() [current 8139too.c] with spin_lock_irqsave() > results in a larger interrupt handler... more CPU instructions for the > same result. Jeff, please be realistic. These interrupt handlers about to do a PIO on a status register, ...

linux-kernel - David Miller - Mar 25 2008 - 23:30