Re: update pms driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexandr Shadchin
Date: Thursday, October 7, 2010 - 12:28 pm

On Wed, Oct 06, 2010 at 09:53:47PM -0400, Kenneth R Westerback wrote:

Removed unnecessary code, as the same thing does pms_change_state() when 
the device enters a state of PMS_STATE_ENABLED

-- 
Alexandr Shadchin

Index: pms.c
===================================================================
RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
retrieving revision 1.8
diff -u -p -r1.8 pms.c
--- pms.c	7 Oct 2010 01:52:25 -0000	1.8
+++ pms.c	7 Oct 2010 18:46:59 -0000
@@ -167,29 +167,11 @@ pmsattach(parent, self, aux)
 	struct pms_softc *sc = (void *)self;
 	struct pckbc_attach_args *pa = aux;
 	struct wsmousedev_attach_args a;
-	u_char cmd[1], resp[2];
-	int res;
 
 	sc->sc_kbctag = pa->pa_tag;
 	sc->sc_kbcslot = pa->pa_slot;
 
 	printf("\n");
-
-	/* Flush any garbage. */
-	pckbc_flush(pa->pa_tag, pa->pa_slot);
-
-	/* reset the device */
-	cmd[0] = PMS_RESET;
-	res = pckbc_poll_cmd(pa->pa_tag, pa->pa_slot, cmd, 1, 2, resp, 1);
-#ifdef DEBUG
-	if (res || resp[0] != PMS_RSTDONE || resp[1] != 0) {
-		printf("pmsattach: reset error\n");
-		return;
-	}
-#endif
-
-	sc->inputstate = 0;
-	sc->oldbuttons = 0;
 
 	pckbc_set_inputhandler(sc->sc_kbctag, sc->sc_kbcslot,
 			       pmsinput, sc, sc->sc_dev.dv_xname);
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: update pms driver, Alexandr Shadchin, (Tue Oct 5, 8:15 am)
Re: update pms driver, Nicholas Marriott, (Tue Oct 5, 10:27 am)
Re: update pms driver, Alexandr Shadchin, (Thu Oct 7, 12:21 pm)
Re: update pms driver, Alexandr Shadchin, (Thu Oct 7, 12:28 pm)
Re: update pms driver, Ian Darwin, (Thu Oct 7, 1:40 pm)
Re: update pms driver, Kenneth R Westerback, (Tue Oct 12, 12:56 pm)
Re: update pms driver, Nicholas Marriott, (Sat Oct 16, 2:46 am)
Re: update pms driver, Alexandr Shadchin, (Sat Oct 16, 5:36 am)
Re: update pms driver, Nicholas Marriott, (Sat Oct 16, 7:42 am)
Re: update pms driver, Alexandr Shadchin, (Sat Oct 16, 8:00 am)
Re: update pms driver, Alexandr Shadchin, (Sun Oct 17, 4:38 am)
Re: update pms driver, Nicholas Marriott, (Mon Oct 18, 11:21 am)
Re: update pms driver, Alexandr Shadchin, (Tue Oct 19, 7:44 am)
Re: update pms driver, Miod Vallat, (Tue Oct 19, 1:03 pm)
Re: update pms driver, Kenneth R Westerback, (Tue Oct 19, 5:39 pm)
Re: update pms driver, Alexandr Shadchin, (Tue Oct 19, 11:59 pm)
Re: update pms driver, Nicholas Marriott, (Sat Oct 30, 5:34 pm)
Re: update pms driver, Alexandr Shadchin, (Sat Nov 6, 11:45 am)
Re: update pms driver, Alexandr Shadchin, (Wed Nov 17, 12:11 pm)
Re: update pms driver, Nicholas Marriott, (Mon Nov 22, 2:44 pm)
Re: update pms driver, Alexandr Shadchin, (Tue Nov 23, 4:10 am)
Re: update pms driver, Nicholas Marriott, (Mon Nov 29, 1:58 pm)
Re: update pms driver, Alexandr Shadchin, (Mon Nov 29, 2:43 pm)
Re: update pms driver, Nicholas Marriott, (Mon Nov 29, 3:08 pm)
Re: update pms driver, Kevin Chadwick, (Tue Nov 30, 5:16 am)
Re: update pms driver, Alexandr Shadchin, (Tue Nov 30, 9:33 am)
Re: update pms driver, Mark Kettenis, (Wed Dec 1, 3:33 am)
Re: update pms driver, Alexandr Shadchin, (Wed Dec 1, 5:14 am)
Re: update pms driver, Nicholas Marriott, (Mon Dec 6, 10:42 am)