Input cleanup of install.sub - Kill the "noglob" statements (which I strongly believe is pure legacy code). Please inform me if I'm wrong. - ask() cleanup: - Strip everything from the first whitespace on by default (much code does not properly handle whitespace in $resp anyway). - A third parameter to ask() can be set to "no" if whitespace is to be kept. - Now uses "read -r" (since I cannot see a need for escapes). - Shell command (e.g. "! ls /mnt") uses 'sh -c' instead of ...

Check for snprintf() return value is incorrect. Should be more like so: i = snprintf(buf, sizeof(buf), BGPCTL " -s %s show rib %s 2> /dev/null", bgpsock, addr); if (i >= sizeof(buf)) /* buf is too small */ return -1; --patrick

Oh, good point, bgpsock is a user-supplied value not a known-length value like addr is (the latter can be no more than 15 bytes), so it is possible that this string could be too long if someone pokes at it, so this case needs checking too. Still, with Claudio's suggestion, I should be able to dispense with the string handling mess. I was roughly following the model of bgplg, but you're right, that does make more sense in this (simpler) case. It would also make sense to display the ...

This is a work-in-progress, but it might be useful for some people who are currently looking at certain AS-path-related things. It uses bgpctl to print the originating AS of the IP address of each hop in traceroute. *It's no use unless you have an internet routing table in bgpd*. (Some other versions of traceroute do this with IRR data via whois, but that method sucks pretty badly). I should really add something like "bgpctl sh fib 1.2.3.4 origin" giving simple output so I can avoid the ...

Yup, try http://www.linux.org.