On Sat, May 02, 2009 at 01:39:53PM +0000, Gilles Chehade wrote:
quoted text
> On Sat, May 02, 2009 at 05:36:52AM -0700, patrick keshishian wrote:
> > On Sat, May 02, 2009 at 12:11:42PM +0100, Stuart Henderson wrote:
> > > +int
> > > +print_asn(char *addr)
> > > +{
> > > +	FILE *f;
> > > +	char buf[1024];
> > > +	int i;
> > > +	int found = 0;
> > >  
> > > +	if (addr == NULL)
> > > +		return -1;
> > > +
> > > +	if(snprintf(buf, 1024, BGPCTL " -s %s show rib %s 2> /dev/null",
> > > +	    bgpsock, addr) == -1)
> > > +		return -1;
> > 
> > Check for snprintf() return value is incorrect. Should be more
> > like so:
> > 
> > 	i = snprintf(buf, sizeof(buf), BGPCTL
> > 		" -s %s show rib %s 2> /dev/null", bgpsock, addr);
> > 	if (i >= sizeof(buf)) /* buf is too small */
> > 		return -1;
> > 
> > 
> 
> Actually it should be more like so:
> 
> i = snprintf(buf, sizeof(buf), BGPCTL,
> 	" -s %s show rib %s 2> /dev/null", bgpsock, addr);
> if (i >= sizeof(buf) || i == -1)
> 	return -1;
> 

Actually I think it should directly talk to the socket and not fork of
bgpctl for every lookup.

-- 
:wq Claudio