Home » Mailing list archives » openbsd-tech » 2009 » May » 11

Re: [PATCH] bioctl(8): fix dd invocation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Schwarze
Subject: Re: [PATCH] bioctl(8): fix dd invocation
Date: Sunday, May 10, 2009 - 6:06 pm

Hi Damien,


I like that.

Not allowing uppercase violates the principle of least surprise for "M"
in particular, but accepting uppercase for all four multipliers is probably
most convenient indeed (without documenting it, of course).

By the way, while here, i suggest improving the STANDARDS section
of the manual page.

 - ascii, ebcdic, ibm are not required by POSIX, but XSI extensions
 - sort oldibm and osync alphabetically
 - note that m and w are not required by POSIX, either

Are you OK with that?


Index: dd.1
===================================================================
RCS file: /cvs/src/bin/dd/dd.1,v
retrieving revision 1.22
diff -u -p -r1.22 dd.1
--- dd.1	8 Feb 2009 17:15:09 -0000	1.22
+++ dd.1	11 May 2009 00:53:05 -0000
@@ -358,11 +358,18 @@ specification.
 .Pp
 The
 .Cm files
-operand as well as the
+operand, the
+.Cm ascii ,
+.Cm ebcdic ,
+.Cm ibm ,
 .Cm oldascii ,
 .Cm oldebcdic ,
-.Cm osync ,
+.Cm oldibm ,
 and
-.Cm oldibm
-values
+.Cm osync
+values, as well as the
+.Sq m
+and
+.Sq w
+size multipliers
 are extensions to that specification.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] bioctl(8): fix dd invocation, Joachim Schipper, (Sat May 9, 3:20 am)
Re: [PATCH] bioctl(8): fix dd invocation, Thordur I. Bjornsson, (Sat May 9, 5:24 am)
Re: [PATCH] bioctl(8): fix dd invocation, Mark Kettenis, (Sat May 9, 5:27 am)
Re: [PATCH] bioctl(8): fix dd invocation, Pierre Riteau, (Sat May 9, 5:30 am)
Re: [PATCH] bioctl(8): fix dd invocation, Joachim Schipper, (Sat May 9, 6:00 am)
Re: [PATCH] bioctl(8): fix dd invocation, Damien Miller, (Sun May 10, 3:53 pm)
Re: [PATCH] bioctl(8): fix dd invocation, Евгений Юнак, (Sun May 10, 5:32 pm)
Re: [PATCH] bioctl(8): fix dd invocation, Ingo Schwarze, (Sun May 10, 6:06 pm)
Re: [PATCH] bioctl(8): fix dd invocation , Theo de Raadt, (Sun May 10, 6:14 pm)
Re: [PATCH] bioctl(8): fix dd invocation , Jacob L. Leifman, (Sun May 10, 7:48 pm)
Re: [PATCH] bioctl(8): fix dd invocation, Stuart Henderson, (Mon May 11, 12:26 am)
Re: [PATCH] bioctl(8): fix dd invocation, Philip Guenther, (Mon May 11, 12:34 am)
Re: [PATCH] bioctl(8): fix dd invocation, Otto Moerbeek, (Mon May 11, 12:58 am)
Re: [PATCH] bioctl(8): fix dd invocation, Han Boetes, (Mon May 11, 1:11 am)
Re: [PATCH] bioctl(8): fix dd invocation, Igor Sobrado, (Mon May 11, 6:06 am)
Re: [PATCH] bioctl(8): fix dd invocation, Marco Peereboom, (Mon May 11, 7:32 am)