On Wed, Feb 18, 2009 at 07:03:19AM +0100, Olli Hauer wrote:
quoted text
> no, this is what I use, it also prevents a failure if someone has a trailing space after the mailaddress (allow entry)
> 
> Index: grey.c
> ===================================================================
> RCS file: /cvs/src/libexec/spamd/grey.c,v
> retrieving revision 1.45
> diff -u -r1.45 grey.c
> --- grey.c  7 Dec 2008 21:12:52 -0000   1.45
> +++ grey.c  18 Feb 2009 06:02:00 -0000
> @@ -319,6 +319,18 @@
>         SLIST_REMOVE_HEAD(&match_suffix, entry);
>     if ((fp = fopen(alloweddomains_file, "r")) != NULL) {
>         while ((buf = fgetln(fp, &len))) {
> +           /* strip white space-characters */
> +           while (len > 0 && isspace(buf[len-1]))
> +               len--;
> +           while (len > 0 && isspace(*buf)) {
> +               buf++;
> +               len--;
> +           }
> +           /* jump over comments and blank lines */
> +           if (*buf == '#' || *buf == '\n')
> +               continue;
> +           if (len == 0)
> +               continue;


You should do your len check before the check for '#' and '\n'.

--patrick