On Sat, 4 Jul 2009 23:24:53 +0100
David Laight wrote:> IMHO using (1 << n) is enough to say 'these might be or'ed together.
I agree that C bit operators are obvious enough, although that may be a
per-project style preference issue. With the bit operators, noone has
to look at whatever the macro may expand to, especially that every
project might define its unstandard wrapper... Moreover, the macros
aren't necessarily shorter or more readable, and they result in less
portable code. It seems that KNF doesn't have a suggestion about it
either.
But I don't have a strong opinion about this.
--
Matt
| Kamalesh Babulal | [BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench |
| Vu Pham | Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel |
| Greg Kroah-Hartman | [PATCH 002/196] Chinese: rephrase English introduction in HOWTO |
| Gabriel C | Re: Linux 2.6.21-rc2 |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | Re: [GIT]: Networking |
| Jeff Garzik | Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" |
