On Sat, Mar 29, 2008 at 04:35:31PM +0000, Matt Fleming wrote:
quoted text
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> As some of you may know I've been working devfs support for NetBSD as
> part of a project for my final year at the University of Leeds.

Woot!

[snip]

quoted text
> Now, for device driver conversion. I've provided an API that device drive=
rs
quoted text
> can use when they need device nodes,
>=20
> int device_register_name(dev_t, device_t, boolean_t, enum devtype,=20
> 	const char *, ...);

You need to add something to indicate if the dev_t is a character or block=
=20
dev_t.

quoted text
> 'devtype' specifies the type of device which will be used for matching ru=
les.
quoted text
> See sys/sys/conf.h for details.
>=20
> int device_unregister_name(dev_t, const char *, ...);
>=20
> We maintain a TAILQ of structs which is appended with the register functi=
on
quoted text
> and has entries removed with the unregister function. When a new struct is
> added to this queue dctl(4) creates a message and places it on an internal
> queue which is picked up by devfsd(8).

Ok, while I can see the need for an unregister_name(), I think what you
really want is device_unregister_all(dev_t, is_block) which zapps
everything for that device.

Saves snprintf()s in detatch. :-)

Actually, if you pass in the device_t, just have=20
device_unregister(device_t) and blow away anything keyed to that device.

quoted text
> Now, an example of how to convert a device driver,
>=20
> void
> mydriver_attach(struct device *parent, struct device *self, void *aux)
> {
> 	int major =3D cdevsw_lookup_major(&mydriver_cdevsw);
> 	int unit =3D device_unit(self);
>=20
> 	device_register_name(makedev(major, unit), self, true,=20
> 	    DEV_OTHER, "mydriver%d", unit);
> }
>=20
> int
> mydriver_detach(struct device *self, int flags)
> {
> 	int major =3D cdevsw_lookup_major(&mydriver_cdevsw);
> 	int unit =3D device_unit(self);
>=20
> 	device_unregister_name(makedev(major, unit), "mydriver%d", unit);
> 	return 0;
> }

Take care,

Bill