Re: [RFC 4/7] USB: Remove bitmap #define from hcd.h

Previous thread: [RFC 01/22] USB 3.0 Hub Changes by Sarah Sharp on Thursday, December 30, 2010 - 4:22 pm. (1 message)

Next thread: [PATCH] qcaux: add Pantech UML290 device ID by Dan Williams on Friday, December 31, 2010 - 9:51 am. (1 message)
From: David Brownell
Date: Thursday, December 30, 2010 - 9:31 pm

Do you think there's any chance of getting the
root cause fixed?

As I recall, this was a workaround for a bad fix.
Some descriptor (hub?) had two adjacent bitfields
with one bit per port (?), and the bad fix removed
a moderately clean representation thereof.  (Maybe
this is what a comment from your patch describes:

 
-    /* two bitmaps:  ports removable, and usb 1.0 legacy PortPwrCtrlMask */
+    /* ports removable, and usb 1.0 legacy PortPwrCtrlMask */

Yes, that #define has always been ugly, but at the
time it seemed a bit less ugly thanjust ignoring
therelevant spec and disregarding the bitmaps.
--

Previous thread: [RFC 01/22] USB 3.0 Hub Changes by Sarah Sharp on Thursday, December 30, 2010 - 4:22 pm. (1 message)

Next thread: [PATCH] qcaux: add Pantech UML290 device ID by Dan Williams on Friday, December 31, 2010 - 9:51 am. (1 message)