On Sun, Dec 19, 2010 at 10:35:40PM +0800, Ming Lei wrote:
quoted text
>Hi,
>
>2010/12/13 Felipe Balbi <balbi@ti.com>:
>>> change all these to EXPORT_SYMBOL_GPL() is glue layer isn't GPL we don't
>>> want it.
>
>OK.
>
>> BTW, changing all DBG() to dev_dbg() on hw glue layer already kills most
>> of the complaints. I think it's better to say musb-omap2430 than
>> musb-hdrc on debug messages comming for omap2430.c as it's a better hint
>> of where the problem is.
>
>Seems many DBG in irq path, and simply changing all DBG in glue driver
>to dev_dbg may cause debug messages flood if debug is enabled, so could
>we not do it at least now?

Don't change to dev_dbg() on IRQ path, only on glue layer. Then we will
have to export musb_debug for the IRQ path. Although I think
musb_interrupt() should not be exported. It should only rely on glue
code to setup musb->int_usb/int_rx/int_tx field correctly. Then, if
needed, also clear IRQ, like it's needed with am35x.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html