Re: [PATCH 28/28] usb: musb: fallback to static method if only one type of DMA is defined | KernelTrap

Re: [PATCH 28/28] usb: musb: fallback to static method if only one type of DMA is defined

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Felipe Balbi

Subject: Re: [PATCH 28/28] usb: musb: fallback to static method if only one type of DMA is defined

Date: Monday, December 13, 2010 - 6:12 am

Hi,

On Mon, Dec 13, 2010 at 04:00:03PM +0300, Sergei Shtylyov wrote:
quoted text>>Sorry, could you explain it in more detail so that I can grasp your idea?
>
>   The #if's will have to grow each time the new DMA engine is added. 
>In fact, I don't see why this patch is even necessary.

I agree with you here Sergei. It's better to just split the thing to its
own platform driver and remove all ifdeferry on DMA usage.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/28] usb: musb: musb cleanup, tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 01/28] usb: musb: introduce get_hw_revision callbac ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 02/28] usb: musb: export some symbols for glue driv ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 02/27] usb: musb: introduce get_hw_revision callbac ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 03/27] usb: musb: export some symbols for glue driv ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 03/28] usb: musb: support to compile hw glue layer ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 04/28] usb: musb: introduce read_fifo/write_fifo ca ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 04/27] usb: musb: support to compile hw glue layer ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 05/27] usb: musb: introduce read_fifo/write_fifo ca ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 05/28] usb: musb: use native read_fifo/write_fifo f ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 06/28] usb: musb: allow all hw glue modules built i ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 06/27] usb: musb: use native read_fifo/write_fifo f ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 07/27] usb: musb: allow all hw glue modules built i ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 07/28] usb: musb: use platform_driver_register to r ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 08/28] usb: musb: pass fifo_mode from hw glue driver, tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 08/27] usb: musb: use platform_driver_register to r ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 09/28] usb: musb: introduce flags field into musb_p ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 09/27] usb: musb: pass fifo_mode from hw glue driver, tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 10/28] usb: musb: handle tusb fifo style by runtime ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 10/27] usb: musb: introduce flags field into musb_p ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 11/27] usb: musb: handle tusb fifo style by runtime ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 11/28] usb: musb: remove musb_in_tusb, tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 12/27] usb: musb: remove musb_in_tusb, tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 12/28] usb: musb: same musb_readb/musb_writeb in si ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 13/27] usb: musb: same musb_readb/musb_writeb in si ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 13/28] usb: musb: simplify musb_ep_select&MUSB_EP_O ..., tom.leiming, (Sun Dec 12, 10:01 am)

[PATCH 14/28] usb: musb: pass musb pointer into musb_ep_se ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 14/27] usb: musb: simplify musb_ep_select&MUSB_EP_O ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 15/27] usb: musb: pass musb pointer into musb_ep_se ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 15/28] usb: musb: same MUSB_OFFSET/musb_ep_select f ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 16/28] usb: musb: define DMA controller related fla ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 16/27] usb: musb: same MUSB_OFFSET/musb_ep_select f ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 17/27] usb: musb: define DMA controller related fla ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 17/28] usb: musb: support each dma controller drive ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 18/28] usb: musb: remove duplicated define of tusb_ ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 18/27] usb: musb: support each dma controller drive ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 19/27] usb: musb: remove duplicated define of tusb_ ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 19/28] usb: musb: remove exit symbol to avoid using ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 20/27] usb: musb: remove exit symbol to avoid using ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 20/28] usb: musb: remove 'ifdef CONFIG_USB_INVENTRA ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 21/28] usb: musb: print dma type in runtime way, tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 21/27] usb: musb: remove 'ifdef CONFIG_USB_INVENTRA ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 22/28] usb: musb: introduce is_inventra_dma helper, tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 22/27] usb: musb: print dma type in runtime way, tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 23/27] usb: musb: introduce is_inventra_dma helper, tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 23/28] usb: musb: remove CONFIG_USB_*_DMA in source ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 24/28] usb: musb: pass musb pointer to is_inventra_ ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 24/27] usb: musb: remove CONFIG_USB_*_DMA in source ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 25/27] usb: musb: pass musb pointer to is_inventra_ ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 25/28] usb: musb: pass musb pointer to tusb_dma_oma ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 26/28] usb: musb: pass musb pointer to is_cppi_enab ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 26/27] usb: musb: pass musb pointer to tusb_dma_oma ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 27/28] usb: musb: implement runtime is_inventra_dma ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 27/27] usb: musb: pass musb pointer to is_cppi_enab ..., tom.leiming, (Sun Dec 12, 10:02 am)

[PATCH 28/28] usb: musb: fallback to static method if only ..., tom.leiming, (Sun Dec 12, 10:02 am)

RE: [PATCH 0/28] usb: musb: musb cleanup, Gupta, Ajay Kumar, (Mon Dec 13, 12:55 am)

Re: [PATCH 01/28] usb: musb: introduce get_hw_revision cal ..., Felipe Balbi, (Mon Dec 13, 1:10 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 1:10 am)

Re: [PATCH 03/28] usb: musb: support to compile hw glue la ..., Felipe Balbi, (Mon Dec 13, 1:11 am)

Re: [PATCH 05/28] usb: musb: use native read_fifo/write_fi ..., Felipe Balbi, (Mon Dec 13, 1:13 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Mon Dec 13, 1:14 am)

Re: [PATCH 08/28] usb: musb: pass fifo_mode from hw glue d ..., Felipe Balbi, (Mon Dec 13, 1:15 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Felipe Balbi, (Mon Dec 13, 1:21 am)

Re: [PATCH 12/28] usb: musb: same musb_readb/musb_writeb i ..., Felipe Balbi, (Mon Dec 13, 1:27 am)

Re: [PATCH 15/28] usb: musb: same MUSB_OFFSET/musb_ep_sele ..., Felipe Balbi, (Mon Dec 13, 1:28 am)

Re: [PATCH 16/28] usb: musb: define DMA controller related ..., Felipe Balbi, (Mon Dec 13, 1:30 am)

Re: [PATCH 22/28] usb: musb: introduce is_inventra_dma helper, Felipe Balbi, (Mon Dec 13, 1:32 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 2:02 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 2:53 am)

Re: [PATCH 0/28] usb: musb: musb cleanup, Ming Lei, (Mon Dec 13, 3:17 am)

Re: [PATCH 0/28] usb: musb: musb cleanup, Ming Lei, (Mon Dec 13, 3:18 am)

Re: [PATCH 03/28] usb: musb: support to compile hw glue la ..., Ming Lei, (Mon Dec 13, 3:28 am)

Re: [PATCH 03/28] usb: musb: support to compile hw glue la ..., Felipe Balbi, (Mon Dec 13, 3:44 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 4:21 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Mon Dec 13, 4:25 am)

Re: [PATCH 12/28] usb: musb: same musb_readb/musb_writeb i ..., Ming Lei, (Mon Dec 13, 4:26 am)

Re: [PATCH 16/28] usb: musb: define DMA controller related ..., Ming Lei, (Mon Dec 13, 4:30 am)

Re: [PATCH 22/28] usb: musb: introduce is_inventra_dma helper, Ming Lei, (Mon Dec 13, 4:37 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Mon Dec 13, 4:46 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 5:00 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 5:11 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Mon Dec 13, 5:17 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Mon Dec 13, 5:31 am)

Re: [PATCH 28/28] usb: musb: fallback to static method if ..., Sergei Shtylyov, (Mon Dec 13, 5:37 am)

Re: [PATCH 28/28] usb: musb: fallback to static method if ..., Ming Lei, (Mon Dec 13, 5:48 am)

Re: [PATCH 28/28] usb: musb: fallback to static method if ..., Sergei Shtylyov, (Mon Dec 13, 6:00 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 6:05 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Mon Dec 13, 6:11 am)

Re: [PATCH 28/28] usb: musb: fallback to static method if ..., Felipe Balbi, (Mon Dec 13, 6:12 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Mon Dec 13, 6:15 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 6:19 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 6:21 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Mon Dec 13, 6:26 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 13, 6:36 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Mon Dec 13, 6:37 am)

Re: [PATCH 28/28] usb: musb: fallback to static method if ..., Ming Lei, (Mon Dec 13, 6:40 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 6:43 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Mon Dec 13, 6:47 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Greg KH, (Mon Dec 13, 9:42 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 9:49 pm)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Mon Dec 13, 9:57 pm)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Tue Dec 14, 4:04 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Wed Dec 15, 4:39 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Felipe Balbi, (Wed Dec 15, 5:32 am)

Re: [PATCH 07/28] usb: musb: use platform_driver_register ..., Ming Lei, (Wed Dec 15, 6:45 am)

Re: [PATCH 08/28] usb: musb: pass fifo_mode from hw glue d ..., Ming Lei, (Wed Dec 15, 11:14 pm)

Re: [PATCH 08/28] usb: musb: pass fifo_mode from hw glue d ..., Felipe Balbi, (Thu Dec 16, 1:48 am)

Re: [PATCH 08/28] usb: musb: pass fifo_mode from hw glue d ..., Ming Lei, (Thu Dec 16, 3:06 am)

Re: [PATCH 08/28] usb: musb: pass fifo_mode from hw glue d ..., Felipe Balbi, (Thu Dec 16, 5:12 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Ming Lei, (Sun Dec 19, 7:35 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Ming Lei, (Sun Dec 19, 7:58 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Felipe Balbi, (Mon Dec 20, 12:27 am)

Re: [PATCH 02/28] usb: musb: export some symbols for glue ..., Felipe Balbi, (Mon Dec 20, 12:30 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Ming Lei, (Mon Dec 20, 12:41 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Felipe Balbi, (Mon Dec 20, 1:29 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Ming Lei, (Mon Dec 20, 2:22 am)

Re: [PATCH 10/28] usb: musb: handle tusb fifo style by run ..., Felipe Balbi, (Mon Dec 20, 2:35 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney	[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger	[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha	[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc:
Theo de Raadt	Re: Old IPSEC bug
Tomáš Bodžár	Problem with vpnc connection - check group password !
Insan Praja SW	Mandoc Compiling Error
Carl Roberso	Re: Cannot change MTU of carp interface?
Richard Daemon	Re: booting openbsd on eee without cd-rom

Colocation donated by:

Syndicate