> On Mon, Dec 13, 2010 at 10:10:39AM +0200, Felipe Balbi wrote:
>>
>> On Mon, Dec 13, 2010 at 01:01:36AM +0800,
tom.leiming@gmail.com wrote:
>>>
>>> From: Ming Lei <tom.leiming@gmail.com>
>>>
>>> Export this functions so that glue drivers can see them if glue drivers
>>> are built as modules.
>>>
>>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>>> ---
>>> drivers/usb/musb/musb_core.c | 7 ++++++-
>>> 1 files changed, 6 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>>> index 2bbf911..070725f 100644
>>> --- a/drivers/usb/musb/musb_core.c
>>> +++ b/drivers/usb/musb/musb_core.c
>>> @@ -116,6 +116,7 @@
>>>
>>>
>>> unsigned musb_debug;
>>> +EXPORT_SYMBOL(musb_debug);
>>
>> change all these to EXPORT_SYMBOL_GPL() is glue layer isn't GPL we don't
>> want it.
>
> BTW, changing all DBG() to dev_dbg() on hw glue layer already kills most
> of the complaints. I think it's better to say musb-omap2430 than
> musb-hdrc on debug messages comming for omap2430.c as it's a better hint
> of where the problem is.
>
> otg_state_string() will be generalized soon with a patchset that's been
> sent already, so most of the problems are killed.
>
> I'm also not sure we want to build glue layer as module, it's just a
> glue layer anyway, and instead of users just modprobe musb_hdrc they'll
> have to modprobe musb-omap2430 && modprobe musb_hdrc, on that order
> otherwise it doesn't work. So keep glue layer as bool, and the same
