From: Harish Zunjarrao <harish.zunjarrao@qlogic.com> The driver should not be unloaded if any application is using it. To disallow driver unload, driver use count must be incremented. Application uses this char device as handle and increases driver use count to avoid possible driver unload. Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 3 ++- drivers/scsi/qla2xxx/qla_os.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 1 ...

From: Giridhar Malavali <giridhar.malavali@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_os.c | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index 3e946da..8217c3b 100644 --- a/drivers/scsi/qla2xxx/qla_gbl.h +++ b/drivers/scsi/qla2xxx/qla_gbl.h @@ -96,6 +96,7 @@ extern int ql2xdontresethba; ...

From: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index c272af4..d416c35 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -1198,9 +1198,11 @@ qla24xx_84xx_fw_version_show(struct device *dev, scsi_qla_host_t ...

From: Andrew Vasquez <andrew.vasquez@qlogic.com> Migrate to a consistent set of debug entries during status-IOCB handling: * group CS_TIMEOUT handling with CS_PORT_UNAVAILABLE and the like (more regrouping of common behaviour). * drop CS_DATA_OVERRUN handling as it now falls into the 'default' case (still returns DID_ERROR). * consolidate CS_RESET and CS_ABORTED handling, as we the only functional difference was a printk() (still returns DID_RESET). * dropped all the earlier ...

From: Madhuranath Iyengar <madhuranath.iyengar@qlogic.com> Currently we can only issue the task management (TM) commands via the mailbox mechanism. This is a limitation, since only one mailbox command can be issued at a time. The purpose of this effort is to provide support for issuing and processing the respose to TM and Marker IOCBs asynchronously. Towards achieving this, the consolidated srb architecture that is currently used for BSG and IOCB/Logio commands has been enhanced and ...

From: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 7 +++ drivers/scsi/qla2xxx/qla_gbl.h | 8 ++++ drivers/scsi/qla2xxx/qla_init.c | 88 ++++++++++++++++++++++++++++++++++++--- drivers/scsi/qla2xxx/qla_iocb.c | 39 ++++++++++++++++- drivers/scsi/qla2xxx/qla_isr.c | 33 +++++++------- drivers/scsi/qla2xxx/qla_os.c | 31 ++++++++++++- 6 files changed, 178 insertions(+), 28 ...

From: Giridhar Malavali <giridhar.malavali@qlogic.com> 1) Allow transition to NEED RESET state only from READY state for ISP82xx. 2) Avoid infinite ISP aborts when chip reset fails. 3) Code cleanup to remove some of the unused debug code. Signed-off-by: Lalit Chandivade <lalit.chandivade@qlogic.com> Signed-off-by: Santosh Vernekar <santosh.vernekar@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_def.h | 2 - ...

From: Arun Easi <arun.easi@qlogic.com> Signed-off-by: Duane Grigsby <duane.grigsby@qlogic.com> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> --- drivers/scsi/qla2xxx/qla_attr.c | 16 + drivers/scsi/qla2xxx/qla_dbg.c | 58 ++++ drivers/scsi/qla2xxx/qla_dbg.h | 10 + drivers/scsi/qla2xxx/qla_def.h | 84 +++++- drivers/scsi/qla2xxx/qla_fw.h | 47 +++- drivers/scsi/qla2xxx/qla_gbl.h | 4 + drivers/scsi/qla2xxx/qla_inline.h | 16 + ...

From: Randy Dunlap <randy.dunlap@oracle.com> bnx2i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET. Also move the dependencies together. The "depends" change fixes multiple build errors when CONFIG_NET is not enabled: ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: ...

From: Randy Dunlap <randy.dunlap@oracle.com> cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET. This change fixes multiple build (link) errors: ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined! ERROR: "init_net" ...

From: Randy Dunlap <randy.dunlap@oracle.com> be2iscsi driver should #include linux/if_ether.h since it uses sysfs_format_mac(). It should also depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET. These changes fix a build error when CONFIG_NET is not enabled: ERROR: "sysfs_format_mac" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Jayamohan Kallickal <jayamohank@serverengines.com> --- ...

sd is using SYNCHRONIZE_CACHE to simulate barrier requests; however no error recovery is taking place as it's being injected from the block layer. So we should be enable retries here to clear any transient error. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/sd.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 8b827f3..de6c603 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1040,6 +1040,7 ...

We have to enable retries for UNIT_ATTENTION sense codes, as a command might've been injected from the block layer (eg barrier requests). And for those no error recovers takes place, so we need to make sure that the SCSI midlayer corrects any transient errors. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/scsi_error.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index ...

I was looking at the wrong source. scsi_finish_command checks for REQ_TYPE_BLOCK_PC and sets good_bytes to scsi_bufflen, so when scsi_io_completion calls scsi_end_request, it --

I tried this, it gets very messy in block, so it looks to be a hack too far. What about this then ... it only retries UAs for barrier commands (thus preserving standard semantics for SG_IO requests)? James --- diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index d45c69c..7ad53fa 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -302,7 +302,20 @@ static int scsi_check_sense(struct scsi_cmnd *scmd) if (scmd->device->allow_restart && ...

Interesting that suddenly several people run into it, when I already noticed long ago. Hmm, you work for Suse, maybe you now got the ticket I have asked our customer about to open for their SLES system? ;) Recent discussion is here: http://kerneltrap.org/mailarchive/linux-scsi/2010/4/19/6884638 Sorry, I didn't have time yet to update the patch there. Cheers, Bernd --

Well, yes, and no. Your patch focussed primarily about the SYNC CACHE command as sent from eg. sd_suspendI() There it's quite easy as I just have to intercept the return values and everything's dandy. sd_prepare_flush(), OTOH, just prepares the command and hopes the lower levels will to the right thing. Which, apparently, they don't. And setting 'retries' or 'timeout' wouldn't help here at all, as we're never evaluating the number of retries; scsi_check_sense() returns 'SUCCESS', ...

https://bugzilla.kernel.org/show_bug.cgi?id=14831 --- Comment #16 from kdesai <kashyap.desai@lsi.com> 2010-05-04 05:16:28 --- I am doing my analysis and meanwhile also in touch with our Firmware folks to understand this issue. Using Ryan's diagnosis tool I am able to see LSI controller is not able to DMA for particular alignment. I will update this ASAP. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ...

Add a feature flag attribute to the multipath structure. Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com> --- drivers/md/dm-mpath.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 826bce7..4200d03 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -82,6 +82,7 @@ struct multipath { unsigned saved_queue_if_no_path;/* Saved state during suspension */ unsigned pg_init_retries; /* ...

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --

This also seems weird, are you coding the API backwards from what SCSI currently has implemented? Would seem a lot cleaner to separate dont-prep from already-prepped. -- Jens Axboe --

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --

This patch series has three sections explained below. The patches are presented as a series as they hit some common functions and may need to be applied in order to avoid conflicts. 1.) Avoid possibly waking up the error handler on a queue that it stopped. blk: Do not abort requests if queue is stopped 2.) It is possible to have a request on the elevator that is already prepped. The prepped resources should be released also. This was seen under heavy IO load while a lot of ...

Having REQ_DONTPREP set on a request can indicated that resources have been allocated for this request. In elv_abort_queue skip requests with REQ_DONTPREP set to avoid leaking resources. Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com> Cc: Jens Axobe <jens.axboe@oracle.com> --- block/elevator.c | 21 ++++++++++++++++++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index df75676..ac98008 100644 --- a/block/elevator.c +++ ...

Call the unprep_fn for the queue if it has been set for requests that have been prepped indicated by REQ_DONTPREP being set. Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com> Cc: Jens Axobe <jens.axboe@oracle.com> --- block/elevator.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index ac98008..1f1e942 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -817,8 +817,12 @@ void elv_abort_queue(struct ...

Add atomic flag for a request to indicate that it has marked as aborted. Provide functions to mark and test the aborted flag. Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com> Cc: Jens Axobe <jens.axboe@oracle.com> --- block/blk-timeout.c | 6 ++++++ block/blk.h | 14 ++++++++++++++ include/linux/blkdev.h | 1 + 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/block/blk-timeout.c b/block/blk-timeout.c index 89fbe0a..ad45b44 100644 --- ...

Add a common scsi_requeue_request function and move previous callers of separate requeue calls to a this common one. This is a preparation step to allow a follow on patch to be added to a common function. Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com> Cc: James Bottomley <James.Bottomley@suse.de> --- drivers/scsi/scsi_lib.c | 53 +++++++++++++++++++++++++--------------------- 1 files changed, 29 insertions(+), 24 deletions(-) diff --git a/drivers/scsi/scsi_lib.c ...

Acked-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) --