Home » Mailing list archives » linux-netdev » 2011 » January » 4

[PATCH v2] net: typos in comments in include/linux/igmp.h

Previous thread: [net-next-2.6 PATCH v5 1/2] net: implement mechanism for HW based QOS by John Fastabend on Tuesday, January 4, 2011 - 11:56 am. (3 messages)

Next thread: Re: [Bugme-new] [Bug 25062] New: Bonding packet deduplication doesn't work properly anymore by Andrew Morton on Tuesday, January 4, 2011 - 2:39 pm. (1 message)
[view original message]
From: Francois-Xavier Le Bail
Subject: [PATCH v2] net: typos in comments in include/linux/igmp.h
Date: Tuesday, January 4, 2011 - 12:10 pm

There are typos in comments in include/linux/igmp.h:

83 #define IGMP_HOST_MEMBERSHIP_QUERY      0x11    /* From RFC1112 */
84 #define IGMP_HOST_MEMBERSHIP_REPORT     0x12    /* Ditto */
[snip]
88 #define IGMPV2_HOST_MEMBERSHIP_REPORT   0x16    /* V2 version of 0x11 */
89 #define IGMP_HOST_LEAVE_MESSAGE         0x17
90 #define IGMPV3_HOST_MEMBERSHIP_REPORT   0x22    /* V3 version of 0x11 */

The line 88 and 90 are about REPORT messages.
The IGMP_HOST_MEMBERSHIP_REPORT (IGMP V1) value is 0x12.
So the comment on line 88 must be /* V2 version of 0x12 */,
and the comment on line 90 must be /* V3 version of 0x12 */.

Signed-off-by: Francois-Xavier Le Bail <fx.lebail@orange.fr>

---

diff -ru a/include/linux/igmp.h b/include/linux/igmp.h
--- a/include/linux/igmp.h	2010-08-27 01:47:12.000000000 +0200
+++ b/include/linux/igmp.h	2010-12-15 09:50:47.808363144 +0100
@@ -85,9 +85,9 @@
 #define IGMP_DVMRP			0x13	/* DVMRP routing */
 #define IGMP_PIM			0x14	/* PIM routing */
 #define IGMP_TRACE			0x15
-#define IGMPV2_HOST_MEMBERSHIP_REPORT	0x16	/* V2 version of 0x11 */
+#define IGMPV2_HOST_MEMBERSHIP_REPORT	0x16	/* V2 version of 0x12 */
 #define IGMP_HOST_LEAVE_MESSAGE 	0x17
-#define IGMPV3_HOST_MEMBERSHIP_REPORT	0x22	/* V3 version of 0x11 */
+#define IGMPV3_HOST_MEMBERSHIP_REPORT	0x22	/* V3 version of 0x12 */
 
 #define IGMP_MTRACE_RESP		0x1e
 #define IGMP_MTRACE			0x1f
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH v2] net: typos in comments in include/linux/igmp.h
Date: Tuesday, January 4, 2011 - 12:30 pm

From: Francois-Xavier Le Bail <fx.lebail@orange.fr>

Applied, thanks.
--


[ message continues ]
Previous thread: [net-next-2.6 PATCH v5 1/2] net: implement mechanism for HW based QOS by John Fastabend on Tuesday, January 4, 2011 - 11:56 am. (3 messages)

Next thread: Re: [Bugme-new] [Bug 25062] New: Bonding packet deduplication doesn't work properly anymore by Andrew Morton on Tuesday, January 4, 2011 - 2:39 pm. (1 message)