Home » Mailing list archives » linux-netdev » 2011 » January » 4

Re: [PATCH v2 06/10] ARM: mx28: update clocks for dual fec support

Previous thread: [PATCH v2 09/10] ARM: mx28: read fec mac address from ocotp by Shawn Guo on Tuesday, January 4, 2011 - 2:24 am. (1 message)

Next thread: [PATCH v2 07/10] ARM: mx28: add the second fec device registration by Shawn Guo on Tuesday, January 4, 2011 - 2:24 am. (1 message)
[view original message]
From: Shawn Guo
Subject: [PATCH v2 06/10] ARM: mx28: update clocks for dual fec support
Date: Tuesday, January 4, 2011 - 2:24 am

Register clocks fec.0 and fec.1 for dual fec support.

Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
Changes for v2:
 - Rebase the patch against patch below which gets fundamental
   clocks explicitly called in clk_enable.
   [PATCH v4] ARM: mxs: Change duart device to use amba-pl011
 - Register clocks fec.0 and fec.1 respectively than use wildcard
   NULL for both instances.

 arch/arm/mach-mxs/clock-mx28.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
index f20b254..f79587b 100644
--- a/arch/arm/mach-mxs/clock-mx28.c
+++ b/arch/arm/mach-mxs/clock-mx28.c
@@ -607,6 +607,7 @@ static struct clk_lookup lookups[] = {
 	/* for amba-pl011 driver */
 	_REGISTER_CLOCK("duart", NULL, uart_clk)
 	_REGISTER_CLOCK("fec.0", NULL, fec_clk)
+	_REGISTER_CLOCK("fec.1", NULL, fec_clk)
 	_REGISTER_CLOCK("rtc", NULL, rtc_clk)
 	_REGISTER_CLOCK("pll2", NULL, pll2_clk)
 	_REGISTER_CLOCK(NULL, "hclk", hbus_clk)
-- 
1.7.1


--


[ message continues ]
[view original message]
From: Uwe Kleine-König
Subject: Re: [PATCH v2 06/10] ARM: mx28: update clocks for dual fec support
Date: Tuesday, January 4, 2011 - 6:58 am

Hello Shawn,

Did you verify this works as intended?  I didn't and consider it
possible that after

	clk_enable("fec.0");
	clk_enable("fec.1");
	clk_disable("fec.1");

the clk is off.  Probably it just works, just want to prevent hard to
find bugs ...

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--


[ message continues ]
[view original message]
From: Shawn Guo
Subject: Re: [PATCH v2 06/10] ARM: mx28: update clocks for dual fec support
Date: Tuesday, January 4, 2011 - 7:26 am

Hi Uwe,

The clk should not be off.  Looking at _REGISTER_CLOCK below, we are
registering both fec.0 and fec.1 on the same one fec_clk.  IOW, the
usecount of the clk is working to control the on/off of the clk.

#define _REGISTER_CLOCK(d, n, c) \
	{ \
		.dev_id = d, \
		.con_id = n, \
		.clk = &c, \
	},

-- 
Regards,
Shawn

--


[ message continues ]
Previous thread: [PATCH v2 09/10] ARM: mx28: read fec mac address from ocotp by Shawn Guo on Tuesday, January 4, 2011 - 2:24 am. (1 message)

Next thread: [PATCH v2 07/10] ARM: mx28: add the second fec device registration by Shawn Guo on Tuesday, January 4, 2011 - 2:24 am. (1 message)