Home » Mailing list archives » linux-netdev » 2011 » January » 3

[patch] mac80211: potential null dereference in mesh forwarding

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dan Carpenter
Subject: [patch] mac80211: potential null dereference in mesh forwarding
Date: Sunday, January 2, 2011 - 10:43 pm

The printk() is supposed to be ratelimited but we should always goto out
when fwd_skb is NULL.  Otherwise it gets dereferenced on the next line.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 5e9d3bc..dc8b566 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -1831,8 +1831,9 @@ ieee80211_rx_h_mesh_fwding(struct ieee80211_rx_data *rx)
 
 			fwd_skb = skb_copy(skb, GFP_ATOMIC);
 
-			if (!fwd_skb && net_ratelimit()) {
-				printk(KERN_DEBUG "%s: failed to clone mesh frame\n",
+			if (!fwd_skb) {
+				if (net_ratelimit())
+					printk(KERN_DEBUG "%s: failed to clone mesh frame\n",
 						   sdata->name);
 				goto out;
 			}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] mac80211: potential null dereference in mesh forwa ..., Dan Carpenter, (Sun Jan 2, 10:43 pm)
Re: [patch] mac80211: potential null dereference in mesh f ..., Eric Dumazet, (Mon Jan 3, 12:45 am)