Home » Mailing list archives » linux-netdev » 2010 » September » 22

Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value
Date: Tuesday, September 21, 2010 - 6:38 pm

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 22 Sep 2010 02:31:36 +0100


Ok, the problem stems merely from the fact that we only specify one
"queue count" in alloc_netdev_mq().  We should specify two, one for
TX and one for RX.

So why not fix that instead of putting hacks into the drivers? :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37, Ben Hutchings, (Mon Sep 20, 11:40 am)
[PATCH net-next-2.6 1/8] ethtool: Define RX n-tuple action ..., Ben Hutchings, (Mon Sep 20, 11:41 am)
[PATCH net-next-2.6 2/8] ethtool: Add Ethernet MAC-level f ..., Ben Hutchings, (Mon Sep 20, 11:42 am)
[PATCH net-next-2.6 3/8] ethtool: Allocate register dump b ..., Ben Hutchings, (Mon Sep 20, 11:42 am)
[PATCH net-next-2.6 4/8] sfc: Add filter table management, Ben Hutchings, (Mon Sep 20, 11:43 am)
[PATCH net-next-2.6 5/8] sfc: Implement the ethtool RX n-t ..., Ben Hutchings, (Mon Sep 20, 11:43 am)
[PATCH net-next-2.6 6/8] sfc: Include RX IP filter table i ..., Ben Hutchings, (Mon Sep 20, 11:43 am)
[PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queue ..., Ben Hutchings, (Mon Sep 20, 11:43 am)
[PATCH net-next-2.6 8/8] sfc: Clean up and correct comment ..., Ben Hutchings, (Mon Sep 20, 11:44 am)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., Eric Dumazet, (Mon Sep 20, 11:54 am)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., Ben Hutchings, (Mon Sep 20, 12:05 pm)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., David Miller, (Tue Sep 21, 2:57 pm)
Re: [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2 ..., David Miller, (Tue Sep 21, 2:58 pm)
Re: [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2 ..., David Miller, (Tue Sep 21, 4:23 pm)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., Ben Hutchings, (Tue Sep 21, 6:31 pm)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., David Miller, (Tue Sep 21, 6:38 pm)
Re: [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2 ..., Ben Hutchings, (Wed Sep 22, 8:27 am)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., Ben Hutchings, (Wed Sep 22, 8:28 am)
Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_q ..., Eric Dumazet, (Wed Sep 22, 8:44 am)