Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Tuesday, September 21, 2010 - 12:33 pm

From: Amit Salecha <amit.salecha@qlogic.com>
Date: Tue, 21 Sep 2010 03:41:42 -0500


Yes, it will.

Do you understand that we enforce both socket-level and system-wide
networking buffer usage in the stack?  And this limiting is based
upon skb->truesize and therefore only works if skb->truesize is
accurate?

It's meant to keep people from attacking a server and consuming large
percentages of system memory with networking buffer memory such that
other tasks cannot complete successfully.

And by mis-reporting the truesize you are subverting that entirely.

This qlcnic truesize bug is a huge security hole, can't you see this
now?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv2 NEXT 0/5]qlcnic: vlan rx accleration support, Amit Kumar Salecha, (Thu Sep 16, 10:14 pm)
[PATCHv2 NEXT 1/5] qlcnic: support vlan rx accleration, Amit Kumar Salecha, (Thu Sep 16, 10:14 pm)
[PATCHv2 NEXT 4/5] qlcnic: remove fw version check, Amit Kumar Salecha, (Thu Sep 16, 10:14 pm)
[PATCHv2 NEXT 5/5] qlcnic: update version 5.0.10, Amit Kumar Salecha, (Thu Sep 16, 10:14 pm)
[PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Eric Dumazet, (Fri Sep 17, 2:57 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Amit Salecha, (Fri Sep 17, 3:53 am)
Re: [PATCHv2 NEXT 0/5]qlcnic: vlan rx accleration support, David Miller, (Fri Sep 17, 11:31 am)
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, David Miller, (Fri Sep 17, 10:58 pm)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Amit Salecha, (Mon Sep 20, 4:16 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Eric Dumazet, (Mon Sep 20, 5:18 am)
[PATCH net-next-2.6] qlnic: dont set skb-&gt;truesize, Eric Dumazet, (Mon Sep 20, 5:28 am)
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, David Miller, (Mon Sep 20, 8:58 am)
Re: [PATCH net-next-2.6] qlnic: dont set skb-&gt;truesize, David Miller, (Mon Sep 20, 10:09 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Amit Salecha, (Tue Sep 21, 1:19 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Eric Dumazet, (Tue Sep 21, 1:34 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Amit Salecha, (Tue Sep 21, 1:41 am)
RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, Eric Dumazet, (Tue Sep 21, 2:23 am)
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2, David Miller, (Tue Sep 21, 12:33 pm)
[PATCH] netxen: dont set skb-&gt;truesize, Eric Dumazet, (Tue Sep 21, 12:55 pm)
Re: [PATCH] netxen: dont set skb-&gt;truesize, David Miller, (Tue Sep 21, 1:04 pm)