Re: [PATCH] sky2: don't do GRO on second port

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Wednesday, September 1, 2010 - 2:51 pm

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 30 Aug 2010 21:09:00 +0200


I'm applying this patch.

Note that for us, devices act as domains, or a key for networking
traffic, whether we like it or not.  Yes, even for the same IP
addresses on the same host.

The reason is that we can do ingress packet editing and the realm of
those rules are per-ingress-qdisc, which are per-device.

The only scenerio you can guarentee that all packets for a given
flow key will be treated the same is the one where the input device
is the same as well.

When there is a single napi --> device mapping, it works, but without
that invariant it doesn't.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC] gro: Is it ok to share a single napi from severa ..., Stephen Hemminger, (Mon Aug 30, 8:57 am)
[PATCH] sky2: don't do GRO on second port, Stephen Hemminger, (Mon Aug 30, 10:51 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Mon Aug 30, 12:09 pm)
Re: [RFC] netpoll: Is it ok to share a single napi from se ..., Stephen Hemminger, (Mon Aug 30, 1:12 pm)
Re: [PATCH] sky2: don't do GRO on second port, David Miller, (Wed Sep 1, 2:51 pm)
Re: [PATCH] sky2: don't do GRO on second port, Stephen Hemminger, (Wed Sep 1, 2:55 pm)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 1:33 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 2:18 am)
Re: [PATCH] sky2: don't do GRO on second port, Eric Dumazet, (Thu Sep 2, 2:31 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 2:32 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 2:55 am)
Re: [PATCH] sky2: don't do GRO on second port, Eric Dumazet, (Thu Sep 2, 3:41 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 4:02 am)
Re: [PATCH] sky2: don't do GRO on second port, Eric Dumazet, (Thu Sep 2, 5:09 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 5:28 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 5:53 am)
Re: [PATCH] sky2: don't do GRO on second port, David Miller, (Thu Sep 2, 9:30 am)
Re: [PATCH] sky2: don't do GRO on second port, Jarek Poplawski, (Thu Sep 2, 9:48 am)
Re: [PATCH] sky2: don't do GRO on second port, David Miller, (Thu Sep 2, 10:08 am)
Re: [PATCH] sky2: don't do GRO on second port, Herbert Xu, (Thu Sep 2, 2:26 pm)
Re: [PATCH] sky2: don't do GRO on second port, Eric Dumazet, (Thu Sep 2, 10:23 pm)