Re: via-velocity dma-debug warnings again. (2.6.35.2)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Wednesday, September 1, 2010 - 1:03 pm

From: Simon Kagstrom <simon.kagstrom@netinsight.net>
Date: Wed, 1 Sep 2010 12:20:59 +0200


That's not the case.

You'll have to use exactly the same formula for computing the length
as the pci_map_single() call uses, which is:

	pktlen = skb_shinfo(skb)->nr_frags == 0 ?
			max_t(unsigned int, skb->len, ETH_ZLEN) :
				skb_headlen(skb);

Otherwise packets smaller than ETH_ZLEN will be unmapped properly
and trigger the same kind of debugging checks Dave is seeing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
via-velocity dma-debug warnings again. (2.6.35.2), Dave Jones, (Mon Aug 30, 6:13 pm)
Re: via-velocity dma-debug warnings again. (2.6.35.2), Simon Kagstrom, (Tue Aug 31, 2:10 am)
Re: via-velocity dma-debug warnings again. (2.6.35.2), Dave Jones, (Tue Aug 31, 10:21 am)
Re: via-velocity dma-debug warnings again. (2.6.35.2), Simon Kagstrom, (Wed Sep 1, 3:20 am)
Re: via-velocity dma-debug warnings again. (2.6.35.2), David Miller, (Wed Sep 1, 1:03 pm)
Re: via-velocity dma-debug warnings again. (2.6.35.2), David Miller, (Wed Sep 1, 1:34 pm)
Re: via-velocity dma-debug warnings again. (2.6.35.2), David Miller, (Wed Sep 1, 1:35 pm)
Re: via-velocity dma-debug warnings again. (2.6.35.2), David Miller, (Wed Sep 1, 1:37 pm)