Le mercredi 01 septembre 2010 à 15:23 -0300, leitao@linux.vnet.ibm.com a
écrit :
quoted text
> This change just add the IBM eHEA 10Gb network drivers as supported.
> 
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>

Hi Breno.

This reminds me something I noticed in this driver.

In receive path, it unconditionally sets skb->ip_summed to
CHECKSUM_UNECESSARY, for _all_ frames, and this seems very suspect.

Shouldnt cqe->inet_checksum_value be checked or something ?

Are frames with bad checksum completely ignored at hardware level ?

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html