Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric Dumazet
Date: Monday, August 23, 2010 - 10:01 pm

Le mardi 24 août 2010 à 07:51 +0300, Plamen Petrov a écrit :

Hmm... I was thinking adding a call __skb_linearize(), just in case...

diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index f5166dc..10928a2 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c
@@ -1696,7 +1696,7 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
 	entry = tp->cur_tx % NUM_TX_DESC;
 
 	/* Note: the chip doesn't have auto-pad! */
-	if (likely(len < TX_BUF_SIZE)) {
+	if (likely(len < TX_BUF_SIZE && !__skb_linearize(skb))) {
 		if (len < ETH_ZLEN)
 			memset(tp->tx_buf[entry], 0, ETH_ZLEN);
 		skb_copy_and_csum_dev(skb, tp->tx_buf[entry]);




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at ..., Eric Dumazet, (Mon Aug 23, 10:01 pm)
[PATCH] net: reset ip_summed in skb_tunnel_rx(), Eric Dumazet, (Sun Aug 29, 12:48 am)
Re: [PATCH] net: reset ip_summed in skb_tunnel_rx(), Jesse Gross, (Sun Aug 29, 8:35 am)