Home » Mailing list archives » linux-netdev » 2010 » August » 13

[PATCH] iputils: arping fails to set correct broadcast address

Previous thread: tproxy related crash in inet_hashtables by Stephen Buck on Friday, August 13, 2010 - 1:15 am. (7 messages)

Next thread: 2.6.35, netfilter/iptables not working with 32bit userspace + 64bit kernel? by Jussi Kivilinna on Friday, August 13, 2010 - 3:47 am. (4 messages)
[view original message]
From: Jesper Dangaard Brouer
Subject: [PATCH] iputils: arping fails to set correct broadcast address
Date: Friday, August 13, 2010 - 2:44 am

From: Paul Martin <pm@debian.org>

There seems to have been introduced a bug in iputils release s20100418.

This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
(git commit fe342ca3148)

The regression is caused by commit 56018bf1b3
 arping: Support link-layer type with larger link-layer address.

As reported by: Paul Martin <pm@debian.org> in Debian bugreport #585591.

 There's a logic error in the function that parses the interface's
 broadcast address, causing it not to fill the broadcast address array
 correctly.

Please apply.

Reported-by: Paul Martin <pm@debian.org>
Tested-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
 arping.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arping.c b/arping.c
index 9bd6927..2613a12 100644
--- a/arping.c
+++ b/arping.c
@@ -336,7 +336,7 @@ void set_device_broadcast(char *device, unsigned char *ba, size_t balen)
 	}
 
 	for (p = ba, ch = 0; p < ba + balen; p++, ch += 3)
-		*p++ = strtoul(brdcast->value + ch * 3, NULL, 16);
+		*p = strtoul(brdcast->value + ch, NULL, 16);
 
 	return;
 }


--


[ message continues ]
[view original message]
From: YOSHIFUJI Hideaki
Subject: Re: [PATCH] iputils: arping fails to set correct broadcast address
Date: Thursday, September 16, 2010 - 1:28 am

Hello.


Applied.  Thank you very much!

--yoshfuji
--


[ message continues ]
Previous thread: tproxy related crash in inet_hashtables by Stephen Buck on Friday, August 13, 2010 - 1:15 am. (7 messages)

Next thread: 2.6.35, netfilter/iptables not working with 32bit userspace + 64bit kernel? by Jussi Kivilinna on Friday, August 13, 2010 - 3:47 am. (4 messages)