Home » Mailing list archives » linux-netdev » 2010 » July » 11

Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock_irqsave in ax_interrupt

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ben Hutchings
Subject: Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock_irqsave in ax_interrupt
Date: Saturday, July 10, 2010 - 7:46 pm

On Sat, 2010-07-10 at 20:18 +0900, Ken Kawasaki wrote:
[...]

I assume this is because it's now called from ei_watchdog() and not only
from interrupt context.  Perhaps you should explain that in the commit
message.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] axnet_cs: fix phy_id detection for bogus Asix chip., Ken Kawasaki, (Sat Apr 4, 5:49 pm)
Re: [PATCH] axnet_cs: fix phy_id detection for bogus Asix ..., David Miller, (Mon Apr 6, 5:42 pm)
[PATCH] pcnet_cs: add cis(firmware) of the Allied Telesis ..., Ken Kawasaki, (Sat Apr 18, 4:44 pm)
[PATCH] 3c589_cs: add cis(firmware) of 3Com multifunction ..., Ken Kawasaki, (Sun Apr 26, 12:29 am)
Re: [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunct ..., Ben Hutchings, (Sun Apr 26, 6:33 am)
Re: [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunct ..., Ken Kawasaki, (Mon Apr 27, 5:48 am)
[PATCH] 3c589_cs: add cis(firmware) of 3Com multifunction ..., Ken Kawasaki, (Mon Apr 27, 5:50 am)
Re: [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunct ..., David Miller, (Fri May 1, 7:22 pm)
[PATCH] pcnet_cs: add new id (RIOS System PC CARD3 ETHERNET), Ken Kawasaki, (Sat Jun 27, 5:09 pm)
Re: [PATCH] pcnet_cs: add new id, David Miller, (Tue Jun 30, 7:19 am)
[PATCH] pcnet_cs: add new id, Ken Kawasaki, (Sat Jul 4, 5:17 pm)
[PATCH] pcnet_cs: add odd location support for write_asic ..., Ken Kawasaki, (Sat Jul 4, 5:19 pm)
Re: [PATCH] pcnet_cs: add new id, Ken Kawasaki, (Sun Jul 5, 1:34 am)
Re: [PATCH] pcnet_cs: add new id, David Miller, (Sun Jul 5, 7:02 pm)
[PATCH] pcnet_cs: add odd location support for write_asic ..., Ken Kawasaki, (Wed Jul 8, 5:09 am)
Re: [PATCH] pcnet_cs: add odd location support for write_a ..., David Miller, (Wed Jul 8, 10:38 am)
[PATCH] pcnet_cs: add odd location support for write_asic ..., Ken Kawasaki, (Fri Jul 10, 5:02 pm)
Re: [PATCH] pcnet_cs: add odd location support for write_a ..., David Miller, (Fri Jul 10, 8:26 pm)
Re: [PATCH] pcnet_cs: add odd location support for write_a ..., Ken Kawasaki, (Sat Jul 11, 3:15 pm)
[PATCH] 3c589_cs: re-initialize the multicast in the tc589 ..., Ken Kawasaki, (Sun Jul 19, 4:08 pm)
Re: [PATCH] 3c589_cs: re-initialize the multicast in the t ..., David Miller, (Mon Jul 20, 8:29 am)
Re: [PATCH] 3c589_cs: re-initialize the multicast in the t ..., Ken Kawasaki, (Wed Jul 22, 5:23 am)
[PATCH] pcnet_cs: add cis of Linksys multifunction pcmcia card, Ken Kawasaki, (Sat Sep 12, 3:22 pm)
[PATCH kernel 2.6.31] pcnet_cs: add cis of Linksys multif ..., Ken Kawasaki, (Sun Sep 13, 1:22 am)
Re: [PATCH kernel 2.6.31] pcnet_cs: add cis of Linksys mul ..., David Miller, (Tue Sep 15, 2:42 am)
[PATCH kernel 2.6.31-git9] 3c574_cs: spin_lock the set_mu ..., Ken Kawasaki, (Sun Sep 20, 9:10 pm)
[PATCH kernel 2.6.32-rc1] pcnet_cs: add cis of National S ..., Ken Kawasaki, (Sat Oct 3, 3:32 pm)
Re: [PATCH kernel 2.6.32-rc1] pcnet_cs: add cis of Nationa ..., David Miller, (Mon Oct 5, 12:40 am)
[PATCH kernel 2.6.32-rc3] 3c574_cs: spin_lock the set_mul ..., Ken Kawasaki, (Sun Oct 11, 5:12 am)
Re: [PATCH kernel 2.6.32-rc3] 3c574_cs: spin_lock the set_ ..., David Miller, (Tue Oct 13, 12:33 am)
[PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax PE- ..., Ken Kawasaki, (Sat Oct 17, 6:39 pm)
Re: [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax ..., Dan Williams, (Wed Oct 21, 12:18 pm)
Re: [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax ..., Ken Kawasaki, (Thu Oct 22, 4:10 am)
Re: [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax ..., Ben Hutchings, (Sat Oct 24, 1:33 pm)
Re: [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax ..., David Miller, (Thu Oct 29, 10:51 pm)
[PATCH kernel 2.6.32-git7] 3c574_cs: disable irq before c ..., Ken Kawasaki, (Sat Dec 12, 5:44 pm)
Re: [PATCH kernel 2.6.32-git7] 3c574_cs: disable irq befor ..., David Miller, (Sun Dec 13, 8:48 pm)
[PATCH kernel 2.6.33-rc1] pcnet_cs: add cis of KTI PE520 ..., Ken Kawasaki, (Mon Dec 21, 4:58 am)
Re: [PATCH kernel 2.6.33-rc1] pcnet_cs: add cis of KTI PE ..., Ben Hutchings, (Tue Dec 22, 7:50 pm)
Re: Re: [PATCH kernel 2.6.33-rc1] pcnet_cs: add cis of KT ..., Ken Kawasaki, (Wed Dec 23, 1:05 am)
[PATCH kernel 2.6.33-rc1 updated] pcnet_cs: add cis of K ..., Ken Kawasaki, (Wed Dec 23, 1:10 am)
[PATCH kernel 2.6.33-rc2] axnet_cs: remove unnecessary sp ..., Ken Kawasaki, (Mon Dec 28, 6:17 pm)
Re: [PATCH kernel 2.6.33-rc1] pcnet_cs: add cis of KTI PE5 ..., David Miller, (Sun Jan 3, 10:42 pm)
Re: [PATCH kernel 2.6.33-rc2] axnet_cs: remove unnecessary ..., David Miller, (Sun Jan 3, 10:52 pm)
[PATCH kernel 2.6.33-rc1 v3] pcnet_cs: add cis of KTI PE ..., Ken Kawasaki, (Mon Jan 4, 4:34 am)
Re: [PATCH kernel 2.6.33-rc1 v3] pcnet_cs: add cis of KTI ..., David Miller, (Wed Jan 6, 9:38 pm)
[PATCH kernel 2.6.33-rc5] fmvj18x_cs: add new id (Panason ..., Ken Kawasaki, (Fri Jan 22, 2:56 pm)
[PATCH kernel 2.6.33] axnet_cs: add new id, Ken Kawasaki, (Sat Feb 27, 4:34 pm)
Re: [PATCH kernel 2.6.33] axnet_cs: add new id, David Miller, (Sun Feb 28, 2:03 am)
[PATCH kernel 2.6.33-git11] lib8390: use spin_lock_irqsav ..., Ken Kawasaki, (Sat Mar 6, 3:02 pm)
[PATCH kernel 2.6.34-rc2] pcnet_cs: add new id, Ken Kawasaki, (Sat Mar 27, 1:55 pm)
Re: [PATCH kernel 2.6.34-rc2] pcnet_cs: add new id, David Miller, (Sat Mar 27, 4:56 pm)
[PATCH kernel 2.6.34-rc3] smc91c92_cs: fix the problem of ..., Ken Kawasaki, (Sat Apr 3, 2:14 pm)
Re: [PATCH kernel 2.6.34-rc3] smc91c92_cs: fix the problem ..., David Miller, (Sat Apr 3, 3:07 pm)
[PATCH kernel 2.6.34-rc3-git9] smc91c92_cs: define multic ..., Ken Kawasaki, (Sat Apr 10, 3:50 pm)
Re: [PATCH kernel 2.6.34-rc3-git9] smc91c92_cs: define mul ..., David Miller, (Tue Apr 13, 3:09 am)
[PATCH kernel 2.6.34-rc5] smc91c92_cs: spin_unlock_irqres ..., Ken Kawasaki, (Sat Apr 24, 1:37 pm)
Re: [PATCH kernel 2.6.34-rc5] smc91c92_cs: spin_unlock_irq ..., David Miller, (Tue Apr 27, 2:47 pm)
[PATCH kernel 2.6.34-rc5] lib8390: to be SMP safe, Ken Kawasaki, (Mon May 3, 3:43 am)
Re: [PATCH kernel 2.6.34-rc5] lib8390: to be SMP safe, Ken Kawasaki, (Thu May 6, 1:47 pm)
[PATCH kernel 2.6.35-rc2] pcnet_cs: add new id (TOSHIBA M ..., Ken Kawasaki, (Sat Jun 12, 3:17 am)
Re: [PATCH kernel 2.6.35-rc2] pcnet_cs: add new id (TOSHIB ..., David Miller, (Wed Jun 16, 6:11 pm)
[PATCH kernel 2.6.35-rc3] smc91c92_cs: fix the problem th ..., Ken Kawasaki, (Sat Jun 19, 6:24 pm)
Re: [PATCH kernel 2.6.35-rc3] smc91c92_cs: fix the problem ..., David Miller, (Fri Jun 25, 9:32 pm)
[PATCH kernel 2.6.35-rc3-git7] axnet_cs: local_irq_save b ..., Ken Kawasaki, (Tue Jul 6, 4:22 am)
Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: local_irq_sav ..., David Miller, (Wed Jul 7, 2:51 pm)
[PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock_ir ..., Ken Kawasaki, (Sat Jul 10, 4:18 am)
Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_loc ..., Ben Hutchings, (Sat Jul 10, 7:46 pm)
Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock ..., David Miller, (Sat Jul 10, 7:49 pm)
Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock ..., Ben Hutchings, (Sat Jul 10, 8:12 pm)
Re: [PATCH kernel 2.6.35-rc3-git7] axnet_cs: use spin_lock ..., David Miller, (Mon Jul 12, 8:08 pm)
[PATCH kernel 2.6.36-rc2] pcnet_cs: add new_id, Ken Kawasaki, (Sat Aug 28, 3:45 pm)
Re: [PATCH kernel 2.6.36-rc2] pcnet_cs: add new_id, David Miller, (Sat Aug 28, 4:07 pm)
[PATCH kernel 2.6.36-git10] pcnet_cs: add new_id, Ken Kawasaki, (Fri Oct 29, 3:17 pm)
Re: [PATCH kernel 2.6.36-git10] pcnet_cs: add new_id, David Miller, (Sat Oct 30, 4:49 pm)
[PATCH kernel 2.6.37-rc1] axnet_cs: fix resume problem fo ..., Ken Kawasaki, (Sat Nov 6, 8:11 am)
Re: [PATCH kernel 2.6.37-rc1] axnet_cs: fix resume problem ..., David Miller, (Fri Nov 12, 3:01 pm)
[PATCH kernel 2.6.37-rc1]ipg.c: remove id [SUNDANCE, 0x1021], Ken Kawasaki, (Sat Nov 13, 4:42 pm)
Re: [PATCH kernel 2.6.37-rc1]ipg.c: remove id [SUNDANCE, 0 ..., David Miller, (Thu Nov 18, 11:45 am)
[PATCH kernel 2.6.37-rc5] axnet_cs: move id (0x1bf, 0x232 ..., Ken Kawasaki, (Mon Dec 13, 5:27 am)
Re: [PATCH kernel 2.6.37-rc5] axnet_cs: move id (0x1bf, 0x ..., David Miller, (Thu Dec 16, 1:39 pm)