On Tue, Jun 29, 2010 at 03:31:34PM -0700, David Miller wrote:
quoted text
> --------------------
> By this I mean you should provide these inline helpers by default
> then we can begin to put them into the drivers.
> --------------------
> 
> This means no config option.

Okay, but what about the PHY time stamping hooks?

I anticipate that people will complain about the "performance penalty"
of these extra checks in a critical path.

Richard


static inline void phy_tx_timestamp(struct phy_device *phy, struct sk_buff *skb)
{
	union skb_shared_tx *shtx = skb_tx(skb);
	if (shtx->hardware && phy && phy->drv->txtstamp)
	   phy->drv->txtstamp(phy, skb);
}

static inline void phy_rx_timestamp(struct phy_device *phy, struct sk_buff *skb)
{
	if (phy && phy->drv->rxtstamp)
	   phy->drv->rxtstamp(phy, skb);
}

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html