From: sonic zhang <sonic.adi@gmail.com>
Date: Tue, 1 Jun 2010 17:19:34 +0800

quoted text
> @@ -1485,6 +1506,10 @@ static int __devinit bfin_mac_probe(struct platform_device *pdev)
>  	ndev->netdev_ops = &bfin_mac_netdev_ops;
>  	ndev->ethtool_ops = &bfin_mac_ethtool_ops;
>  
> +	init_timer(&lp->tx_reclaim_timer);
> +	lp->tx_reclaim_timer.data = (unsigned long)(lp);

Putting parenthesis around "lp" is excessive, please don't do this.

quoted text
> +	lp->tx_reclaim_timer.function = (void *)tx_reclaim_skb;
> +
>  	spin_lock_init(&lp->lock);

Do not cast the function pointer to "void *" like this, it's ugly and entirely
not necessary.

Instead have a wrapper function that uses the correct types as specified
for timer functions, that calls the existing function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html