Home » Mailing list archives » linux-netdev » 2010 » June » 19

Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup code
Date: Friday, June 18, 2010 - 10:15 pm

I've applied this series however:

1) Please address Ben's concerns about turning EEE on by default
   given that standardization is not complete yet.

2) I hate module parameters, I'd rather you create a new ethtool
   feature bit and thus allow the setting to be modified at run
   time.  Please create a new ethtool control flag, and remove
   this module option.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback ..., Jeff Kirsher, (Wed Jun 16, 4:25 pm)
[net-next-2.6 PATCH 2/8] e1000e: cleanup e1000_sw_lcd_conf ..., Jeff Kirsher, (Wed Jun 16, 4:26 pm)
[net-next-2.6 PATCH 3/8] e1000e: separate out PHY statisti ..., Jeff Kirsher, (Wed Jun 16, 4:26 pm)
[net-next-2.6 PATCH 4/8] e1000e: fix check for manageabili ..., Jeff Kirsher, (Wed Jun 16, 4:27 pm)
[net-next-2.6 PATCH 5/8] e1000e: initial support for 82579 ..., Jeff Kirsher, (Wed Jun 16, 4:27 pm)
[net-next-2.6 PATCH 6/8] e1000e: enable support for EEE on ..., Jeff Kirsher, (Wed Jun 16, 4:27 pm)
[net-next-2.6 PATCH 7/8] e1000e: update copyright information, Jeff Kirsher, (Wed Jun 16, 4:28 pm)
[net-next-2.6 PATCH 8/8] e1000e: update driver version number, Jeff Kirsher, (Wed Jun 16, 4:28 pm)
Re: [net-next-2.6 PATCH 6/8] e1000e: enable support for EE ..., Ben Hutchings, (Wed Jun 16, 4:52 pm)
Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., David Miller, (Fri Jun 18, 10:15 pm)
Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., Jeff Kirsher, (Sun Jun 20, 12:32 am)
Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., David Miller, (Sun Jun 20, 2:48 pm)
RE: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., Allan, Bruce W, (Wed Jun 30, 3:41 pm)
Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., David Miller, (Wed Jun 30, 4:06 pm)
RE: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopb ..., Ben Hutchings, (Thu Jul 1, 8:55 am)