Home » Mailing list archives » linux-netdev » 2010 » June » 18

Re: [PATCH] socketcan: add a driver for FlexCAN controllers.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Wolfgang Grandegger
Subject: Re: [PATCH] socketcan: add a driver for FlexCAN controllers.
Date: Friday, June 18, 2010 - 2:47 am

Hi Hans-Jürgen,

On 06/17/2010 12:52 PM, Hans J. Koch wrote:

I briefly browsed the patch and various bits and pieces are missing or
not correctly implemented. Marc already pointed out a few of them:

- I do not find can_put/get_echo_skb functions in the code. How is
  IFF_ECHO supposed to work?

- Support for CAN_CTRLMODE_BERR_REPORTING and do_get_berr_counter()
  seems to be missing.

- Make use of alloc_can_skb() and alloc_can_err_skb().

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] socketcan: add a driver for FlexCAN controllers., Hans J. Koch, (Thu Jun 17, 3:52 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Marc Kleine-Budde, (Thu Jun 17, 7:10 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 2:47 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 3:04 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Marc Kleine-Budde, (Fri Jun 18, 3:16 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 3:33 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Marc Kleine-Budde, (Fri Jun 18, 3:44 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 4:04 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Marc Kleine-Budde, (Fri Jun 18, 4:21 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 4:53 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Hans J. Koch, (Fri Jun 18, 5:00 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 5:19 am)
Re: [PATCH] socketcan: add a driver for FlexCAN controllers., Wolfgang Grandegger, (Fri Jun 18, 5:30 am)