Home » Mailing list archives » linux-netdev » 2010 » May » 3

Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem
Date: Monday, May 3, 2010 - 1:04 pm

And btw, your commit message should have explained all of the things
you're telling me here.  Rather than just mention some vague "problem".

Your commit messages should explain everything about why you're
making the change, not just say what changes are being made.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/13] Micrel KSZ8851 updates and fixes, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 01/13] KS8851: Fix ks8851 snl transmit problem, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 02/13] KSZ8851-SNL: Fix receive interrupt problem., Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 05/13] KSZ8851-SNL: Add support for EEPROM MAC address, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 06/13] KSZ8851-SNL: Fix MAC address change problem, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 07/13] KSZ8851-SNL: Add ethtool support for EEPROM, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 08/13] KSZ8851-SNL: Fix EEPROM access problem, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 09/13] KSZ8851-SNL: Add debugfs export for driver state, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 10/13] KS8851: ks8851_mll.c: Use the ks8851.h heade ..., Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 11/13] KS8851: Update ks8851.h header from ks8851_mll.c, Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 12/13] KS8851: Use the ks8851.h header to hold unio ..., Ben Dooks, (Thu Apr 29, 4:16 pm)
[patch 13/13] KSZ8851-SNL: Add platform data to specific I ..., Ben Dooks, (Thu Apr 29, 4:16 pm)
Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, David Miller, (Sun May 2, 10:38 pm)
RE: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, Ha, Tristram, (Mon May 3, 12:06 pm)
Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, David Miller, (Mon May 3, 1:03 pm)
Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, David Miller, (Mon May 3, 1:04 pm)
RE: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, Ha, Tristram, (Mon May 3, 2:11 pm)
Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem, David Miller, (Mon May 3, 2:13 pm)