>
quoted text
> It might be better to test the comparisons using
> a cpu_to_le32 of the constants.
>
Yes.  Probably should also be changed in nv_tx_done{_optimized} and
nv_rx_process{_optimized}

quoted text
> static inline int nv_has_work(struct fe_priv *np)
> {
>        if (nv_optimized(np))
>                return ((np->get_rx.ex != np->put_rx.ex) &&
>                        !(np->get_rx.ex->flaglen & cpu_to_le32(NV_RX2_AVAIL))) ||
>                       ((np->get_tx.ex != np->put_tx.ex) &&
>                        !(np->get_tx.ex->flaglen & cpu_to_le32(NV_TX_VALID)));
>
>        return ((np->get_rx.orig != np->put_rx.orig) &&
>                !(np->get_rx.orig->flaglen & cpu_to_le32(NV_RX_AVAIL))) ||
>               ((np->get_tx.orig != np->put_tx.orig) &&
>                !(np->get_tx.orig->flaglen & cpu_to_le32(NV_TX_VALID)));
> }
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html