[PATCH net-next 4/4] bridge: multicast_flood cleanup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stephen Hemminger
Date: Tuesday, April 27, 2010 - 6:01 pm

Move some declarations around to make it clearer which variables
are being used inside loop.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/bridge/br_forward.c	2010-04-27 17:58:25.739592056 -0700
+++ b/net/bridge/br_forward.c	2010-04-27 17:59:17.182654034 -0700
@@ -208,17 +208,15 @@ static void br_multicast_flood(struct ne
 {
 	struct net_device *dev = BR_INPUT_SKB_CB(skb)->brdev;
 	struct net_bridge *br = netdev_priv(dev);
-	struct net_bridge_port *port;
-	struct net_bridge_port *lport, *rport;
-	struct net_bridge_port *prev;
+	struct net_bridge_port *prev = NULL;
 	struct net_bridge_port_group *p;
 	struct hlist_node *rp;
 
-	prev = NULL;
-
 	rp = rcu_dereference(br->router_list.first);
 	p = mdst ? rcu_dereference(mdst->ports) : NULL;
 	while (p || rp) {
+		struct net_bridge_port *port, *lport, *rport;
+
 		lport = p ? p->port : NULL;
 		rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) :
 			     NULL;

-- 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH net-next 0/4] Bridge IGMP cleanup and fixes, Stephen Hemminger, (Tue Apr 27, 6:01 pm)
[PATCH net-next 1/4] bridge: simplify multicast_add_router, Stephen Hemminger, (Tue Apr 27, 6:01 pm)
[PATCH net-next 2/4] bridge: multicast flood, Stephen Hemminger, (Tue Apr 27, 6:01 pm)
[PATCH net-next 3/4] bridge: multicast port group RCU fix, Stephen Hemminger, (Tue Apr 27, 6:01 pm)
[PATCH net-next 4/4] bridge: multicast_flood cleanup, Stephen Hemminger, (Tue Apr 27, 6:01 pm)
Re: [PATCH net-next 0/4] Bridge IGMP cleanup and fixes, David Miller, (Tue Apr 27, 6:14 pm)
Re: [PATCH net-next 3/4] bridge: multicast port group RCU fix, Stephen Hemminger, (Tue Apr 27, 8:47 pm)