Home » Mailing list archives » linux-netdev » 2010 » April » 27

Re: [PATCH net-next] bridge: multicast router list manipulation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [PATCH net-next] bridge: multicast router list manipulation
Date: Tuesday, April 27, 2010 - 4:51 pm

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 27 Apr 2010 16:44:12 -0700


Fair enough, I've reverted by change.

This would have been helped if either the patch was split up into
two pieces (one straight hlist macro conversion, another removing
the RCU tag) _or_ the commit message explained why the RCU tag
could be elided.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC] [1/13] bridge: Add IGMP snooping support, Herbert Xu, (Fri Feb 26, 8:34 am)
[PATCH 1/13] bridge: Do br_pass_frame_up after other ports, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 2/13] bridge: Allow tail-call on br_pass_frame_up, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 3/13] bridge: Avoid unnecessary clone on forward path, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 4/13] bridge: Use BR_INPUT_SKB_CB on xmit path, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 5/13] bridge: Split may_deliver/deliver_clone out o ..., Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 7/13] bridge: Add multicast forwarding functions, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 8/13] bridge: Add multicast start/stop hooks, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 9/13] bridge: Add multicast data-path hooks, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 10/13] bridge: Add multicast_router sysfs entries, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 11/13] bridge: Add multicast_snooping sysfs toggle, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 12/13] bridge: Add hash elasticity/max sysfs entries, Herbert Xu, (Fri Feb 26, 8:35 am)
[PATCH 13/13] bridge: Add multicast count/interval sysfs e ..., Herbert Xu, (Fri Feb 26, 8:35 am)
Re: [PATCH 10/13] bridge: Add multicast_router sysfs entries, Stephen Hemminger, (Fri Feb 26, 5:42 pm)
Re: [PATCH 2/13] bridge: Allow tail-call on br_pass_frame_up, David Miller, (Sat Feb 27, 4:14 am)
Re: [PATCH 10/13] bridge: Add multicast_router sysfs entries, David Miller, (Sat Feb 27, 4:29 am)
Re: [PATCH 2/13] bridge: Allow tail-call on br_pass_frame_up, Herbert Xu, (Sat Feb 27, 8:36 am)
Re: [PATCH 10/13] bridge: Add multicast_router sysfs entries, Herbert Xu, (Sat Feb 27, 8:53 am)
[1/13] bridge: Add IGMP snooping support, Herbert Xu, (Sat Feb 27, 10:40 pm)
[PATCH 1/13] bridge: Do br_pass_frame_up after other ports, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 2/13] bridge: Allow tail-call on br_pass_frame_up, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 3/13] bridge: Avoid unnecessary clone on forward path, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 4/13] bridge: Use BR_INPUT_SKB_CB on xmit path, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 5/13] bridge: Split may_deliver/deliver_clone out o ..., Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 7/13] bridge: Add multicast forwarding functions, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 8/13] bridge: Add multicast start/stop hooks, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 9/13] bridge: Add multicast data-path hooks, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 10/13] bridge: Add multicast_router sysfs entries, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 11/13] bridge: Add multicast_snooping sysfs toggle, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 12/13] bridge: Add hash elasticity/max sysfs entries, Herbert Xu, (Sat Feb 27, 10:41 pm)
[PATCH 13/13] bridge: Add multicast count/interval sysfs e ..., Herbert Xu, (Sat Feb 27, 10:41 pm)
Re: [1/13] bridge: Add IGMP snooping support, David Miller, (Sun Feb 28, 1:52 am)
Re: [1/13] bridge: Add IGMP snooping support, Herbert Xu, (Sun Feb 28, 7:08 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Fri Mar 5, 4:43 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Fri Mar 5, 6:17 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Fri Mar 5, 10:06 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Fri Mar 5, 11:56 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Sat Mar 6, 12:03 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Sat Mar 6, 12:07 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Sat Mar 6, 8:00 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Sat Mar 6, 8:19 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Sat Mar 6, 12:00 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Sat Mar 6, 7:45 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Sat Mar 6, 8:11 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, David Miller, (Sun Mar 7, 4:31 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, David Miller, (Sun Mar 7, 4:31 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Mon Mar 8, 11:50 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Mon Mar 8, 8:15 pm)
Re: [PATCH 10/13] bridge: Add multicast_router sysfs entries, Herbert Xu, (Tue Mar 9, 5:25 am)
Re: [PATCH 10/13] bridge: Add multicast_router sysfs entries, Herbert Xu, (Tue Mar 9, 5:26 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Tue Mar 9, 2:12 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Tue Mar 9, 7:14 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Wed Mar 10, 2:41 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Eric Dumazet, (Wed Mar 10, 3:39 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Wed Mar 10, 3:49 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Wed Mar 10, 6:13 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Wed Mar 10, 6:19 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Wed Mar 10, 6:27 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Wed Mar 10, 6:30 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Wed Mar 10, 6:39 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Wed Mar 10, 6:57 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Herbert Xu, (Wed Mar 10, 7:07 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Wed Mar 10, 9:26 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, David Miller, (Wed Mar 10, 9:35 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Wed Mar 10, 10:56 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Wed Mar 10, 2:25 pm)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Arnd Bergmann, (Thu Mar 11, 11:49 am)
Re: [PATCH 6/13] bridge: Add core IGMP snooping support, Paul E. McKenney, (Sun Mar 14, 4:01 pm)
[PATCH net-next] bridge: use is_multicast_ether_addr, Stephen Hemminger, (Tue Apr 27, 10:13 am)
[PATCH net-next] bridge: multicast router list manipulation, Stephen Hemminger, (Tue Apr 27, 10:13 am)
Re: [PATCH net-next] bridge: use is_multicast_ether_addr, David Miller, (Tue Apr 27, 12:53 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., David Miller, (Tue Apr 27, 12:54 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., Michał Mirosław, (Tue Apr 27, 4:11 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., Stephen Hemminger, (Tue Apr 27, 4:25 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., David Miller, (Tue Apr 27, 4:27 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., David Miller, (Tue Apr 27, 4:28 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., Stephen Hemminger, (Tue Apr 27, 4:44 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., David Miller, (Tue Apr 27, 4:51 pm)
Re: [PATCH net-next] bridge: multicast router list manipul ..., Herbert Xu, (Tue Apr 27, 6:51 pm)