Re: [PATCH] gianfar: Wait for both RX and TX to stop

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Timur Tabi
Date: Wednesday, April 21, 2010 - 7:33 am

On Wed, Apr 21, 2010 at 7:17 AM, Kumar Gala <galak@kernel.crashing.org> wrote:


And how else will you detect and recover from such a failure without a
timeout?  And are you absolutely certain that there will never be a
programming failure that will cause this loop to spin forever?

If you're really opposed to a timeout, you can still use
spin_event_timeout() by just setting the timeout to -1 and adding a
comment explaining why.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] gianfar: Wait for both RX and TX to stop, Andy Fleming, (Sun Apr 18, 4:13 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Timur Tabi, (Mon Apr 19, 2:08 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Kumar Gala, (Mon Apr 19, 9:43 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Kumar Gala, (Mon Apr 19, 9:44 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, David Miller, (Tue Apr 20, 1:18 am)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Timur Tabi, (Tue Apr 20, 8:01 am)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Timur Tabi, (Tue Apr 20, 8:59 am)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, David Miller, (Tue Apr 20, 6:06 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Kumar Gala, (Tue Apr 20, 9:22 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, David Miller, (Tue Apr 20, 10:36 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Kumar Gala, (Wed Apr 21, 5:17 am)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Timur Tabi, (Wed Apr 21, 7:33 am)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, Kumar Gala, (Wed Apr 21, 12:13 pm)
Re: [PATCH] gianfar: Wait for both RX and TX to stop, David Miller, (Wed Apr 21, 2:33 pm)