Home » Mailing list archives » linux-netdev » 2010 » April » 20

[PATCH] bridge: add a missing ntohs()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric Dumazet
Subject: [PATCH] bridge: add a missing ntohs()
Date: Tuesday, April 20, 2010 - 6:20 am

Found by code review and sparse endianness warning, I am not sure this
patch is valid.

Thanks

[PATCH] bridge: add a missing ntohs()

grec_nsrcs is in network order, we should convert to host horder in
br_multicast_igmp3_report()

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index f29ada8..386c153 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -727,7 +727,7 @@ static int br_multicast_igmp3_report(struct net_bridge *br,
 		group = grec->grec_mca;
 		type = grec->grec_type;
 
-		len += grec->grec_nsrcs * 4;
+		len += ntohs(grec->grec_nsrcs) * 4;
 		if (!pskb_may_pull(skb, len))
 			return -EINVAL;
 



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] bridge: add a missing ntohs(), Eric Dumazet, (Tue Apr 20, 6:20 am)
Re: [PATCH] bridge: add a missing ntohs(), Herbert Xu, (Tue Apr 20, 6:30 am)
Re: [PATCH] bridge: add a missing ntohs(), David Miller, (Tue Apr 20, 6:21 pm)