Home » Mailing list archives » linux-netdev » 2010 » March » 9

[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stanislaw Gruszka
Subject: [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
Date: Tuesday, March 9, 2010 - 9:55 am

Since we want to keep ordering of write to fp->bd_tx_cons and
netif_tx_queue_stopped(txq), what is read of txq->state, we have to use
general memory barrier.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/bnx2x_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index ed785a3..9fc0f6a 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -963,7 +963,7 @@ static int bnx2x_tx_int(struct bnx2x_fastpath *fp)
 	 * start_xmit() will miss it and cause the queue to be stopped
 	 * forever.
 	 */
-	smp_wmb();
+	smp_mb();
 
 	/* TBD need a thresh? */
 	if (unlikely(netif_tx_queue_stopped(txq))) {
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read w ..., Stanislaw Gruszka, (Tue Mar 9, 9:55 am)
Re: [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of re ..., Eilon Greenstein, (Wed Mar 10, 8:59 am)
Re: [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of re ..., David Miller, (Mon Mar 15, 3:47 pm)